Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Hotfix/remove unused methods #1725

Merged
merged 5 commits into from
Aug 30, 2024
Merged

Hotfix/remove unused methods #1725

merged 5 commits into from
Aug 30, 2024

Conversation

Peguen
Copy link
Contributor

@Peguen Peguen commented Aug 30, 2024

Description

For specific platform builds warning are treated as errors. To fix those:

  • removed unused methods
  • commented unused parameter
  • changed "MaxReconnectionAttempts" back to int, as also the logic needs -1 for infinite attempts
  • removed config-keys from globals init (as its also not used anymore and the functionality itself is gone)

@Peguen Peguen requested a review from rex-schilasky August 30, 2024 06:13
@Peguen Peguen added the cherry-pick-to-NONE Don't cherry-pick these changes label Aug 30, 2024
@Peguen Peguen merged commit 5359894 into master Aug 30, 2024
20 of 22 checks passed
@Peguen Peguen deleted the hotfix/remove_unused_methods branch August 30, 2024 06:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rex-schilasky rex-schilasky rex-schilasky approved these changes

Assignees
No one assigned
Labels
cherry-pick-to-NONE Don't cherry-pick these changes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Peguen @rex-schilasky