[core] Reworked various API calls for v6 release (Initialize, IsInitialized, SetUnitName, GetVersionXXX) #1841

hannemn · 2024-12-06T07:34:24Z

Refers to issue #1832, section ecal_core.h.

Furthermore python and C wrapper signatures has been aligned with C++ API changes.

…tions has been removed or modified.

github-actions

clang-tidy made some suggestions

There were too many comments to post at once. Showing the first 20 out of 162. Check the log or trigger a new build to see more.

github-actions · 2024-12-06T08:02:08Z

app/mon/mon_cli/src/ecal_mon_cli.cpp

@@ -209,7 +209,7 @@ int main(int argc, char** argv)
    }

    // initialize eCAL API
-    eCAL::Initialize(0, nullptr, "eCALMon CLI", eCAL::Init::All);
+    eCAL::Initialize("eCALMon CLI", eCAL::Init::All);


warning: no header providing "eCAL::Init::All" is directly included [misc-include-cleaner]

app/mon/mon_cli/src/ecal_mon_cli.cpp:23:

- #include <atomic> + #include "ecal/ecal_init.h" + #include <atomic>

github-actions · 2024-12-06T08:02:08Z

app/mon/mon_cli/src/ecal_mon_cli.cpp

@@ -209,7 +209,7 @@
    }

    // initialize eCAL API
-    eCAL::Initialize(0, nullptr, "eCALMon CLI", eCAL::Init::All);
+    eCAL::Initialize("eCALMon CLI", eCAL::Init::All);


warning: no header providing "eCAL::Initialize" is directly included [misc-include-cleaner]

app/mon/mon_cli/src/ecal_mon_cli.cpp:23:

- #include <atomic> + #include "ecal/ecal_core.h" + #include <atomic>

github-actions · 2024-12-06T08:02:08Z

app/mon/mon_gui/src/ecalmon.cpp

@@ -71,7 +71,7 @@ Ecalmon::Ecalmon(QWidget *parent)
  , monitor_error_counter_(0)
 {
  // Just make sure that eCAL is initialized
-  eCAL::Initialize(0, nullptr, "eCALMon", eCAL::Init::Default | eCAL::Init::Monitoring);
+  eCAL::Initialize("eCALMon", eCAL::Init::Default | eCAL::Init::Monitoring);


warning: no header providing "eCAL::Init::Default" is directly included [misc-include-cleaner]

app/mon/mon_gui/src/ecalmon.cpp:24:

- #include "widgets/about_dialog/about_dialog.h" + #include "ecal/ecal_init.h" + #include "widgets/about_dialog/about_dialog.h"

github-actions · 2024-12-06T08:02:08Z

app/mon/mon_gui/src/ecalmon.cpp

@@ -71,7 +71,7 @@
  , monitor_error_counter_(0)
 {
  // Just make sure that eCAL is initialized
-  eCAL::Initialize(0, nullptr, "eCALMon", eCAL::Init::Default | eCAL::Init::Monitoring);
+  eCAL::Initialize("eCALMon", eCAL::Init::Default | eCAL::Init::Monitoring);


warning: no header providing "eCAL::Init::Monitoring" is directly included [misc-include-cleaner]

eCAL::Initialize("eCALMon", eCAL::Init::Default | eCAL::Init::Monitoring); ^

github-actions · 2024-12-06T08:02:08Z

app/mon/mon_gui/src/ecalmon.cpp

@@ -71,7 +71,7 @@
  , monitor_error_counter_(0)
 {
  // Just make sure that eCAL is initialized
-  eCAL::Initialize(0, nullptr, "eCALMon", eCAL::Init::Default | eCAL::Init::Monitoring);
+  eCAL::Initialize("eCALMon", eCAL::Init::Default | eCAL::Init::Monitoring);


warning: no header providing "eCAL::Initialize" is directly included [misc-include-cleaner]

app/mon/mon_gui/src/ecalmon.cpp:24:

- #include "widgets/about_dialog/about_dialog.h" + #include "ecal/ecal_core.h" + #include "widgets/about_dialog/about_dialog.h"

github-actions · 2024-12-06T08:02:10Z

app/play/play_gui/src/main.cpp

@@ -159,7 +159,7 @@
  //////////////////////////////////////////////////////////////////////////////

  // Just make sure that eCAL is initialized
-  eCAL::Initialize(0, nullptr, "eCALPlayGUI", eCAL::Init::Default | eCAL::Init::Publisher | eCAL::Init::Service | eCAL::Init::Monitoring);
+  eCAL::Initialize("eCALPlayGUI", eCAL::Init::Default | eCAL::Init::Publisher | eCAL::Init::Service | eCAL::Init::Monitoring);


warning: no header providing "eCAL::Initialize" is directly included [misc-include-cleaner]

app/play/play_gui/src/main.cpp:19:

- #include "ecal_play_gui.h" + #include "ecal/ecal_core.h" + #include "ecal_play_gui.h"

github-actions · 2024-12-06T08:02:10Z

app/play/play_gui/src/widgets/about_dialog/about_dialog.cpp

@@ -32,7 +32,7 @@ AboutDialog::AboutDialog(QWidget *parent)
  ui_.version_label->setText("Version: " + QString(EcalPlayGlobals::VERSION_STRING));
  ui_.ecalversion_label->setText("eCAL " + QString(ECAL_VERSION) + " (" + QString(ECAL_DATE) + ")");

-  ui_.ecal_runtime_version_string_label->setText(QString(eCAL::GetVersionString()) + " (" + QString(eCAL::GetVersionDateString()) + ")");
+  ui_.ecal_runtime_version_string_label->setText(QString::fromStdString(eCAL::GetVersionString()) + " (" + QString::fromStdString(eCAL::GetVersionDateString()) + ")");


warning: no header providing "eCAL::GetVersionDateString" is directly included [misc-include-cleaner]

ui_.ecal_runtime_version_string_label->setText(QString::fromStdString(eCAL::GetVersionString()) + " (" + QString::fromStdString(eCAL::GetVersionDateString()) + ")"); ^

github-actions · 2024-12-06T08:02:10Z

app/play/play_gui/src/widgets/about_dialog/about_dialog.cpp

@@ -32,7 +32,7 @@
  ui_.version_label->setText("Version: " + QString(EcalPlayGlobals::VERSION_STRING));
  ui_.ecalversion_label->setText("eCAL " + QString(ECAL_VERSION) + " (" + QString(ECAL_DATE) + ")");

-  ui_.ecal_runtime_version_string_label->setText(QString(eCAL::GetVersionString()) + " (" + QString(eCAL::GetVersionDateString()) + ")");
+  ui_.ecal_runtime_version_string_label->setText(QString::fromStdString(eCAL::GetVersionString()) + " (" + QString::fromStdString(eCAL::GetVersionDateString()) + ")");


warning: no header providing "eCAL::GetVersionString" is directly included [misc-include-cleaner]

app/play/play_gui/src/widgets/about_dialog/about_dialog.cpp:20:

- #include "ecal_play_globals.h" + #include "ecal/ecal_core.h" + #include "ecal_play_globals.h"

github-actions · 2024-12-06T08:02:10Z

app/rec/rec_client_core/src/ecal_rec.cpp

@@ -36,7 +36,7 @@ namespace eCAL

    EcalRec::EcalRec()
    {
-      eCAL::Initialize(0, nullptr, "eCALRecClient", eCAL::Init::Default | eCAL::Init::Monitoring);
+      eCAL::Initialize("eCALRecClient", eCAL::Init::Default | eCAL::Init::Monitoring);


warning: no header providing "eCAL::Init::Default" is directly included [misc-include-cleaner]

app/rec/rec_client_core/src/ecal_rec.cpp:21:

- #include "ecal_rec_impl.h" + #include "ecal/ecal_init.h" + #include "ecal_rec_impl.h"

github-actions · 2024-12-06T08:02:10Z

app/rec/rec_client_core/src/ecal_rec.cpp

@@ -36,7 +36,7 @@

    EcalRec::EcalRec()
    {
-      eCAL::Initialize(0, nullptr, "eCALRecClient", eCAL::Init::Default | eCAL::Init::Monitoring);
+      eCAL::Initialize("eCALRecClient", eCAL::Init::Default | eCAL::Init::Monitoring);


warning: no header providing "eCAL::Init::Monitoring" is directly included [misc-include-cleaner]

eCAL::Initialize("eCALRecClient", eCAL::Init::Default | eCAL::Init::Monitoring); ^

github-actions

clang-tidy made some suggestions

There were too many comments to post at once. Showing the first 20 out of 142. Check the log or trigger a new build to see more.

github-actions · 2024-12-06T10:12:11Z

app/rec/rec_client_core/src/ecal_rec.cpp

@@ -36,7 +36,7 @@ namespace eCAL

    EcalRec::EcalRec()
    {
-      eCAL::Initialize(0, nullptr, "eCALRecClient", eCAL::Init::Default | eCAL::Init::Monitoring);
+      eCAL::Initialize("eCALRecClient", eCAL::Init::Default | eCAL::Init::Monitoring);


warning: no header providing "eCAL::Initialize" is directly included [misc-include-cleaner]

app/rec/rec_client_core/src/ecal_rec.cpp:21:

- #include "ecal_rec_impl.h" + #include "ecal/ecal_core.h" + #include "ecal_rec_impl.h"

github-actions · 2024-12-06T10:12:11Z

app/rec/rec_gui/src/main.cpp

@@ -136,7 +136,7 @@ int main(int argc, char *argv[])
  }

  // Just make sure that eCAL is initialized
-  eCAL::Initialize(0, nullptr, "eCALRecGUI", eCAL::Init::Default | eCAL::Init::Service | eCAL::Init::Monitoring);
+  eCAL::Initialize("eCALRecGUI", eCAL::Init::Default | eCAL::Init::Service | eCAL::Init::Monitoring);


warning: no header providing "eCAL::Init::Default" is directly included [misc-include-cleaner]

app/rec/rec_gui/src/main.cpp:19:

- #include "ecalrec_gui.h" + #include "ecal/ecal_init.h" + #include "ecalrec_gui.h"

github-actions · 2024-12-06T10:12:11Z

app/rec/rec_gui/src/main.cpp

@@ -136,7 +136,7 @@
  }

  // Just make sure that eCAL is initialized
-  eCAL::Initialize(0, nullptr, "eCALRecGUI", eCAL::Init::Default | eCAL::Init::Service | eCAL::Init::Monitoring);
+  eCAL::Initialize("eCALRecGUI", eCAL::Init::Default | eCAL::Init::Service | eCAL::Init::Monitoring);


warning: no header providing "eCAL::Init::Monitoring" is directly included [misc-include-cleaner]

eCAL::Initialize("eCALRecGUI", eCAL::Init::Default | eCAL::Init::Service | eCAL::Init::Monitoring); ^

github-actions · 2024-12-06T10:12:11Z

app/rec/rec_gui/src/main.cpp

@@ -136,7 +136,7 @@
  }

  // Just make sure that eCAL is initialized
-  eCAL::Initialize(0, nullptr, "eCALRecGUI", eCAL::Init::Default | eCAL::Init::Service | eCAL::Init::Monitoring);
+  eCAL::Initialize("eCALRecGUI", eCAL::Init::Default | eCAL::Init::Service | eCAL::Init::Monitoring);


warning: no header providing "eCAL::Init::Service" is directly included [misc-include-cleaner]

eCAL::Initialize("eCALRecGUI", eCAL::Init::Default | eCAL::Init::Service | eCAL::Init::Monitoring); ^

github-actions · 2024-12-06T10:12:11Z

app/rec/rec_gui/src/main.cpp

@@ -136,7 +136,7 @@
  }

  // Just make sure that eCAL is initialized
-  eCAL::Initialize(0, nullptr, "eCALRecGUI", eCAL::Init::Default | eCAL::Init::Service | eCAL::Init::Monitoring);
+  eCAL::Initialize("eCALRecGUI", eCAL::Init::Default | eCAL::Init::Service | eCAL::Init::Monitoring);


warning: no header providing "eCAL::Initialize" is directly included [misc-include-cleaner]

app/rec/rec_gui/src/main.cpp:19:

- #include "ecalrec_gui.h" + #include "ecal/ecal_core.h" + #include "ecalrec_gui.h"

github-actions · 2024-12-06T10:12:13Z

app/sys/sys_client_cli/src/ecal_sys_client_cli.cpp

@@ -113,7 +113,7 @@
    logger->info("eCAL Sys Client was started with " + accept_security_risk_arg.longID() + ". Not displaying security warning.");
  }

-  eCAL::Initialize(argc, argv, "eCALSysClient", eCAL::Init::Default | eCAL::Init::Monitoring);
+  eCAL::Initialize("eCALSysClient", eCAL::Init::Default | eCAL::Init::Monitoring);


warning: no header providing "eCAL::Init::Monitoring" is directly included [misc-include-cleaner]

eCAL::Initialize("eCALSysClient", eCAL::Init::Default | eCAL::Init::Monitoring); ^

github-actions · 2024-12-06T10:12:14Z

app/sys/sys_client_cli/src/ecal_sys_client_cli.cpp

@@ -113,7 +113,7 @@
    logger->info("eCAL Sys Client was started with " + accept_security_risk_arg.longID() + ". Not displaying security warning.");
  }

-  eCAL::Initialize(argc, argv, "eCALSysClient", eCAL::Init::Default | eCAL::Init::Monitoring);
+  eCAL::Initialize("eCALSysClient", eCAL::Init::Default | eCAL::Init::Monitoring);


warning: no header providing "eCAL::Initialize" is directly included [misc-include-cleaner]

app/sys/sys_client_cli/src/ecal_sys_client_cli.cpp:31:

- #include "ecal_sys_client_service.h" + #include "ecal/ecal_core.h" + #include "ecal_sys_client_service.h"

github-actions · 2024-12-06T10:12:14Z

app/sys/sys_gui/src/main.cpp

@@ -144,7 +144,7 @@ int main(int argc, char *argv[])
  //////////////////////////////////////////////////////////////////////////////

  // Just make sure that eCAL is initialized
-  eCAL::Initialize(argc, argv, "eCALSysGUI", eCAL::Init::All);
+  eCAL::Initialize("eCALSysGUI", eCAL::Init::All);


warning: no header providing "eCAL::Init::All" is directly included [misc-include-cleaner]

app/sys/sys_gui/src/main.cpp:19:

- #include "ecalsys_gui.h" + #include "ecal/ecal_init.h" + #include "ecalsys_gui.h"

github-actions · 2024-12-06T10:12:14Z

app/sys/sys_gui/src/main.cpp

@@ -144,7 +144,7 @@
  //////////////////////////////////////////////////////////////////////////////

  // Just make sure that eCAL is initialized
-  eCAL::Initialize(argc, argv, "eCALSysGUI", eCAL::Init::All);
+  eCAL::Initialize("eCALSysGUI", eCAL::Init::All);


warning: no header providing "eCAL::Initialize" is directly included [misc-include-cleaner]

app/sys/sys_gui/src/main.cpp:19:

- #include "ecalsys_gui.h" + #include "ecal/ecal_core.h" + #include "ecalsys_gui.h"

github-actions · 2024-12-06T10:12:14Z

app/sys/sys_gui/src/widgets/about_dialog/about_dialog.cpp

@@ -32,7 +32,7 @@ AboutDialog::AboutDialog(QWidget *parent)
  ui_.version_label->setText("Version: " + QString(ECAL_SYS_VERSION_STRING));
  ui_.ecalversion_label->setText("eCAL " + QString(ECAL_VERSION) + " (" + QString(ECAL_DATE) + ")");

-  ui_.ecal_runtime_version_string_label->setText(QString(eCAL::GetVersionString()) + " (" + QString(eCAL::GetVersionDateString()) + ")");
+  ui_.ecal_runtime_version_string_label->setText(QString::fromStdString(eCAL::GetVersionString()) + " (" + QString::fromStdString(eCAL::GetVersionDateString()) + ")");


warning: no header providing "eCAL::GetVersionDateString" is directly included [misc-include-cleaner]

ui_.ecal_runtime_version_string_label->setText(QString::fromStdString(eCAL::GetVersionString()) + " (" + QString::fromStdString(eCAL::GetVersionDateString()) + ")"); ^

hannemn and others added 7 commits December 5, 2024 16:03

Reworked ecal core API for version 6 release. Several public API func…

9e0909c

…tions has been removed or modified.

Removed config cmd parser test

55aad0d

Fixed ecal_c_core test

5fcd5ea

Fixed warnings and errors in multiple tests.

544867e

Fixed further tests.

757a936

Adapted python code and associated clang wrapper.

30bd570

Merge branch 'master' into feature/ecal-core-api-v6

d6664ba

hannemn added the cherry-pick-to-NONE Don't cherry-pick these changes label Dec 6, 2024

github-actions bot reviewed Dec 6, 2024

View reviewed changes

Set deprecation warning for python method initialize(args, unit_name).

9a4dde6

hannemn requested review from KerstinKeller, rex-schilasky and Peguen December 6, 2024 09:46

github-actions bot reviewed Dec 6, 2024

View reviewed changes

rex-schilasky approved these changes Dec 6, 2024

View reviewed changes

rex-schilasky merged commit a451039 into master Dec 6, 2024
20 checks passed

rex-schilasky deleted the feature/ecal-core-api-v6 branch December 6, 2024 13:03

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[core] Reworked various API calls for v6 release (Initialize, IsInitialized, SetUnitName, GetVersionXXX) #1841

[core] Reworked various API calls for v6 release (Initialize, IsInitialized, SetUnitName, GetVersionXXX) #1841

hannemn commented Dec 6, 2024 •

edited

Loading

github-actions bot left a comment

github-actions bot Dec 6, 2024

github-actions bot Dec 6, 2024

github-actions bot Dec 6, 2024

github-actions bot Dec 6, 2024

github-actions bot Dec 6, 2024

github-actions bot Dec 6, 2024

github-actions bot Dec 6, 2024

github-actions bot Dec 6, 2024

github-actions bot Dec 6, 2024

github-actions bot Dec 6, 2024

github-actions bot left a comment

github-actions bot Dec 6, 2024

github-actions bot Dec 6, 2024

github-actions bot Dec 6, 2024

github-actions bot Dec 6, 2024

github-actions bot Dec 6, 2024

github-actions bot Dec 6, 2024

github-actions bot Dec 6, 2024

github-actions bot Dec 6, 2024

github-actions bot Dec 6, 2024

github-actions bot Dec 6, 2024

[core] Reworked various API calls for v6 release (Initialize, IsInitialized, SetUnitName, GetVersionXXX) #1841

[core] Reworked various API calls for v6 release (Initialize, IsInitialized, SetUnitName, GetVersionXXX) #1841

Conversation

hannemn commented Dec 6, 2024 • edited Loading

github-actions bot left a comment

Choose a reason for hiding this comment

github-actions bot Dec 6, 2024

Choose a reason for hiding this comment

github-actions bot Dec 6, 2024

Choose a reason for hiding this comment

github-actions bot Dec 6, 2024

Choose a reason for hiding this comment

github-actions bot Dec 6, 2024

Choose a reason for hiding this comment

github-actions bot Dec 6, 2024

Choose a reason for hiding this comment

github-actions bot Dec 6, 2024

Choose a reason for hiding this comment

github-actions bot Dec 6, 2024

Choose a reason for hiding this comment

github-actions bot Dec 6, 2024

Choose a reason for hiding this comment

github-actions bot Dec 6, 2024

Choose a reason for hiding this comment

github-actions bot Dec 6, 2024

Choose a reason for hiding this comment

github-actions bot left a comment

Choose a reason for hiding this comment

github-actions bot Dec 6, 2024

Choose a reason for hiding this comment

github-actions bot Dec 6, 2024

Choose a reason for hiding this comment

github-actions bot Dec 6, 2024

Choose a reason for hiding this comment

github-actions bot Dec 6, 2024

Choose a reason for hiding this comment

github-actions bot Dec 6, 2024

Choose a reason for hiding this comment

github-actions bot Dec 6, 2024

Choose a reason for hiding this comment

github-actions bot Dec 6, 2024

Choose a reason for hiding this comment

github-actions bot Dec 6, 2024

Choose a reason for hiding this comment

github-actions bot Dec 6, 2024

Choose a reason for hiding this comment

github-actions bot Dec 6, 2024

Choose a reason for hiding this comment

hannemn commented Dec 6, 2024 •

edited

Loading