[core] get service id implementation #1875
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
Peguen
reviewed
Jan 7, 2025
| service_id.service_id.host_name = Process::GetHostName(); | ||
|
|
||
| service_id.service_name = m_service_name; | ||
| service_id.method_name = ""; |
There was a problem hiding this comment.
Why is the method_name an empty string?
There was a problem hiding this comment.
The method_name field is used in other internal contexts (for example as key in ServiceIdInfoMap) but here the method name makes no sense. I will introduce a new SServiceId type additional to the existing SServiceMethodId for now. The new type will cover service and client instance id's and the other one will be used to get ID's of service-methods. Let me try .. ;-)
…SServiceMethodId type when method name is not needed
KerstinKeller
approved these changes
Jan 8, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Implements
GetServiceIdforCServiceClientandCServiceServer.