[mon_gui] Logging enable, crash fix #1878
Draft
+18
−10
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
| @@ -241,7 +241,9 @@ void LogModel::insertLogs(const eCAL::pb::LogMessageList& logging_pb) | |||
| // Add new elements to the bottom | |||
| size_before = logs_.size(); | |||
| int size_after = (size_before + inserted_row_count < max_entries_ ? size_before + inserted_row_count : max_entries_); | |||
| beginInsertRows(QModelIndex(), size_before, size_after - 1); | |||
| bool insert_row = size_before <= size_after - 1; | |||
There was a problem hiding this comment.
warning: variable 'insert_row' of type 'bool' can be declared 'const' [misc-const-correctness]
Suggested change
| bool insert_row = size_before <= size_after - 1; | |
| ;const |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Enable logging receiving in mon_gui.
Check size of rows before adding them in log_model.cpp . Without that size check, in debug the monitor crashed through an assert.