[config] Small hotfix for path_processing and logging to file #1917
+104
−89
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…laced with current yaml path.
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
| { | ||
| return false; | ||
| } | ||
| } |
There was a problem hiding this comment.
I am not 100% sure if this is the best way to check if you have write access to a directory.
What happens if you can't delete the file anymore?
I would guess that there are system functions that can check write access to a directory.
KerstinKeller
approved these changes
Jan 20, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Logging to file expected a path separator at the end of the path. This now will be checked beforehand and handled accordingly.
GeteCALLogDirImpl used to check the local user and system path separately. Now its connected to the yaml file path. In case no LOG_VAR, DATA_VAR or config path is set, it tries to log to the folder where the ecal configuration yaml was loaded from.