Feature/ecal service namespace #1933
Conversation
KerstinKeller
added
Auto Approve
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
| eCAL::Logging::Log(eCAL::Logging::log_level_debug4, "[" + node_name + "] " + message); | ||
| break; | ||
| case LogLevel::Debug: | ||
| case ecal_service::LogLevel::Debug: |
There was a problem hiding this comment.
warning: switch has 2 consecutive identical branches [bugprone-branch-clone]
case ecal_service::LogLevel::Debug:
^Additional context
ecal/core/src/service/ecal_service_singleton_manager.cpp:46: last of these clones ends here
break;
^|
|
||
| namespace ecal_service | ||
| { | ||
| enum class LogLevel |
There was a problem hiding this comment.
warning: enum 'LogLevel' uses a larger base type ('int', size: 4 bytes) than necessary for its value set, consider using 'std::uint8_t' (1 byte) as the base type to reduce its size [performance-enum-size]
enum class LogLevel
^| { | ||
| namespace service | ||
| constexpr std::uint8_t ClientSessionV1::MIN_SUPPORTED_PROTOCOL_VERSION; |
There was a problem hiding this comment.
warning: redundant 'MIN_SUPPORTED_PROTOCOL_VERSION' declaration [readability-redundant-declaration]
| constexpr std::uint8_t ClientSessionV1::MIN_SUPPORTED_PROTOCOL_VERSION; | |
Additional context
ecal/service/ecal_service/src/client_session_impl_v1.h:148: previously declared here
static constexpr std::uint8_t MIN_SUPPORTED_PROTOCOL_VERSION = 1;
^| { | ||
| namespace service | ||
| constexpr std::uint8_t ClientSessionV1::MIN_SUPPORTED_PROTOCOL_VERSION; | ||
| constexpr std::uint8_t ClientSessionV1::MAX_SUPPORTED_PROTOCOL_VERSION; |
There was a problem hiding this comment.
warning: redundant 'MAX_SUPPORTED_PROTOCOL_VERSION' declaration [readability-redundant-declaration]
| constexpr std::uint8_t ClientSessionV1::MAX_SUPPORTED_PROTOCOL_VERSION; | |
Additional context
ecal/service/ecal_service/src/client_session_impl_v1.h:149: previously declared here
static constexpr std::uint8_t MAX_SUPPORTED_PROTOCOL_VERSION = 1;
^| { | ||
| namespace service | ||
| constexpr std::uint8_t ServerSessionV1::MIN_SUPPORTED_PROTOCOL_VERSION; |
There was a problem hiding this comment.
warning: redundant 'MIN_SUPPORTED_PROTOCOL_VERSION' declaration [readability-redundant-declaration]
| constexpr std::uint8_t ServerSessionV1::MIN_SUPPORTED_PROTOCOL_VERSION; | |
Additional context
ecal/service/ecal_service/src/server_session_impl_v1.h:93: previously declared here
static constexpr std::uint8_t MIN_SUPPORTED_PROTOCOL_VERSION = 1;
^| { | ||
| namespace service | ||
| constexpr std::uint8_t ServerSessionV1::MIN_SUPPORTED_PROTOCOL_VERSION; | ||
| constexpr std::uint8_t ServerSessionV1::MAX_SUPPORTED_PROTOCOL_VERSION; |
There was a problem hiding this comment.
warning: redundant 'MAX_SUPPORTED_PROTOCOL_VERSION' declaration [readability-redundant-declaration]
| constexpr std::uint8_t ServerSessionV1::MAX_SUPPORTED_PROTOCOL_VERSION; | |
Additional context
ecal/service/ecal_service/src/server_session_impl_v1.h:94: previously declared here
static constexpr std::uint8_t MAX_SUPPORTED_PROTOCOL_VERSION = 1;
^
Description
We need to prepare eCAL for the upcoming changes in the core, by introducing a new namespace / header file structure for ecal_service, to avoid name clashes later on.