Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[core] rearrange service and pubsub headers into folders. #1934

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

KerstinKeller
Copy link
Contributor

New folder structure for headers:

ecal
  pubsub
    publisher.h
    subscriber.h
    payload_writerr.h
    types.h
  service
    client.h
    server.h
    client_instance.h
    types.h

@KerstinKeller KerstinKeller added the cherry-pick-to-NONE Don't cherry-pick these changes label Jan 22, 2025
Copy link
Contributor

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

clang-tidy made some suggestions

#include <ecal/ecal_time.h>
#include <ecal/ecal_timer.h>
#include <ecal/ecal_tlayer.h>
#include <ecal/ecal_util.h>
#include <ecal/config/configuration.h>
#include <ecal/pubsub/publisher.h>
#include <ecal/pubsub/subscriber.h>
#include <ecal/service/client.h>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

warning: duplicate include [readability-duplicate-include]

ecal/core/include/ecal/ecal.h:45:

- #include <ecal/pubsub/subscriber.h>
- #include <ecal/service/client.h>
+ #include <ecal/pubsub/subscriber.h>

#include <ecal/pubsub/publisher.h>
#include <ecal/pubsub/subscriber.h>
#include <ecal/service/client.h>
#include <ecal/service/server.h>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

warning: duplicate include [readability-duplicate-include]

ecal/core/include/ecal/ecal.h:46:

#include <ecal/ecal_publisher.h>
#include <ecal/ecal_subscriber.h>
#include <ecal/pubsub/publisher.h>
#include <ecal/pubsub/subscriber.h>

#include <gtest/gtest.h>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

warning: 'gtest/gtest.h' file not found [clang-diagnostic-error]

#include <gtest/gtest.h>
         ^

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cherry-pick-to-NONE Don't cherry-pick these changes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant