Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Remove Junit dependency and move test to proper module #4040

Merged
merged 1 commit into from
Mar 23, 2024

Conversation

jimmarino
Copy link
Contributor

@jimmarino jimmarino commented Mar 23, 2024

What this PR changes/adds

Cleans up an unused dependency and test.

Linked Issue(s)

Related to #4028

@jimmarino jimmarino added the refactoring Cleaning up code and dependencies label Mar 23, 2024
@jimmarino jimmarino requested a review from wolf4ood March 23, 2024 07:55
@codecov-commenter
Copy link

codecov-commenter commented Mar 23, 2024

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 74.03%. Comparing base (7f20ba5) to head (7cbe260).
Report is 460 commits behind head on main.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #4040      +/-   ##
==========================================
+ Coverage   71.74%   74.03%   +2.28%     
==========================================
  Files         919      989      +70     
  Lines       18457    20053    +1596     
  Branches     1037     1126      +89     
==========================================
+ Hits        13242    14846    +1604     
+ Misses       4756     4726      -30     
- Partials      459      481      +22     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@jimmarino jimmarino merged commit 08df476 into eclipse-edc:main Mar 23, 2024
19 of 22 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
refactoring Cleaning up code and dependencies
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants