Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: deprecate DAPS module #4538

Merged
merged 2 commits into from
Oct 10, 2024

Conversation

ndr-brt
Copy link
Member

@ndr-brt ndr-brt commented Oct 10, 2024

What this PR changes/adds

Deprecate oauth2-daps module and releated classes.

Why it does that

cleanup

Further notes

  • given that the code effort was minimal, I included the DR in the same PR

Linked Issue(s)

Closes #4534

Please be sure to take a look at the contributing guidelines and our etiquette for pull requests.

@ndr-brt ndr-brt added the documentation Improvements or additions to documentation label Oct 10, 2024
@ndr-brt ndr-brt marked this pull request as ready for review October 10, 2024 09:26

In EDC version 0.10.0 we deprecated:
- module `oauth2-daps`
- class `Oauth2ServiceImpl`
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Deprecating DAPS is independent from removing OAuth2 as identity system. If we want to do that, that would require a separate D-R, and we should also remove the controplane-oauth-bom

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would not remove the oauth2 AFAIK daps module is only an oauth2 extensions with custom decorators. We should probably 🪓 only that

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@paullatzelsperger What are the motivations to keep oauth2 as identity system? I'd go with a single axe blow for both as we want to push toward DCP anyway. I can eventually adapt the D-R accordingly

Copy link
Member

@paullatzelsperger paullatzelsperger Oct 10, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

its just that both this PR and the decision record are about deprecating DAPS, not Oauth2, the decision was made to axe the earlier, not the latter.

@ndr-brt ndr-brt merged commit 48cee15 into eclipse-edc:main Oct 10, 2024
25 checks passed
ndr-brt added a commit that referenced this pull request Oct 10, 2024
* docs: deprecate DAPS module

* pr remark
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Deprecate DAPS modules
3 participants