-
Notifications
You must be signed in to change notification settings - Fork 244
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs: deprecate DAPS module #4538
docs: deprecate DAPS module #4538
Conversation
|
||
In EDC version 0.10.0 we deprecated: | ||
- module `oauth2-daps` | ||
- class `Oauth2ServiceImpl` |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Deprecating DAPS is independent from removing OAuth2 as identity system. If we want to do that, that would require a separate D-R, and we should also remove the controplane-oauth-bom
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I would not remove the oauth2
AFAIK daps module is only an oauth2 extensions with custom decorators. We should probably 🪓 only that
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@paullatzelsperger What are the motivations to keep oauth2 as identity system? I'd go with a single axe blow for both as we want to push toward DCP anyway. I can eventually adapt the D-R accordingly
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
its just that both this PR and the decision record are about deprecating DAPS, not Oauth2, the decision was made to axe the earlier, not the latter.
* docs: deprecate DAPS module * pr remark
What this PR changes/adds
Deprecate
oauth2-daps
module and releated classes.Why it does that
cleanup
Further notes
Linked Issue(s)
Closes #4534
Please be sure to take a look at the contributing guidelines and our etiquette for pull requests.