Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: set INFO as default log level, downgraded some log calls #4629

Merged
merged 1 commit into from
Nov 14, 2024

Conversation

ndr-brt
Copy link
Member

@ndr-brt ndr-brt commented Nov 14, 2024

What this PR changes/adds

Sets INFO as default log level when the default ConsoleMonitor instance is created.
Switch some INFO logs to DEBUG (especially in the startup phase).

Why it does that

log cleanup

Further notes

  • refactored the way monitor extensions are loaded, before was through a static method that duplicated the logic already existing in ServiceLocator

Linked Issue(s)

Closes #4625

Please be sure to take a look at the contributing guidelines and our etiquette for pull requests.

@ndr-brt ndr-brt added the refactoring Cleaning up code and dependencies label Nov 14, 2024
@ndr-brt ndr-brt requested a review from wolf4ood November 14, 2024 14:31
Copy link
Member

@paullatzelsperger paullatzelsperger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

❤️

Copy link
Contributor

@jimmarino jimmarino left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀 🪓

@ndr-brt ndr-brt merged commit c5da66f into eclipse-edc:main Nov 14, 2024
21 checks passed
@ndr-brt ndr-brt deleted the 4625-shrink-logs branch November 14, 2024 15:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
refactoring Cleaning up code and dependencies
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Shrink down logs
3 participants