refactor(test): make Participant lazy
#4723
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ndr-brt
force-pushed
the
4710-make-participant-lazy
branch
2 times, most recently
from
c54b5a3 to
f4c5484
Compare
ndr-brt
force-pushed
the
4710-make-participant-lazy
branch
3 times, most recently
from
d0086b5 to
565df03
Compare
ndr-brt
force-pushed
the
4710-make-participant-lazy
branch
from
565df03 to
39e88f1
Compare
paullatzelsperger
approved these changes
Jan 15, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR changes/adds
Completes the work done in #4712 by making
Participantclass lazy in creating port configurations.Why it does that
avoid testcontainers flaky tests
Further notes
Endpointclass has been deprecated, as it was just an unnecessary wrapper around RestAssured'sRequestSpecification. with the addition of aenrichManagementRequestadopters can eventually enrich the management request used by tests object (e.g. by adding authentication headers, as it is currently done in the tractusx-edc tests).protocolendpoint, as it is not supposed to be called in E2E tests that are meant to be "management api user" facing.EmbeddedRuntimestartup timeout because the "restart data flows" activity is making data-plane slower to startLinked Issue(s)
Closes #4710
Please be sure to take a look at the contributing guidelines and our etiquette for pull requests.