Remove DTDL Parser #50
Conversation
ashbeitz
commented
Oct 6, 2023
•
ashbeitz
commented
- Removes the minimalistic DTDL parser.
- Add a C# based app that uses the .Net DTDLParser to validate DTDL files.
- The minimalistic DTDL parser was forcing us to rely on the nightly Rust release. With it removed, we can no rely on the stable release.
- The streaming sample uses an OSS license that we so not wish to use. Its build step has been deactivated until it can be changed to no longer depend on the show-image crate.
Alex Recommends ReportAlex recommends the following language changes, but Alex is a regular expression based algorithm, so take them with a grain of salt. ✨ 🚀 ✨ Nothing to Report ✨ 🚀 ✨ |
This comment was marked as duplicate.
This comment was marked as duplicate.
Sorry, something went wrong.
|
This pull request sets up GitHub code scanning for this repository. Once the scans have completed and the checks have passed, the analysis results for this pull request branch will appear on this overview. Once you merge this pull request, the 'Security' tab will show more code scanning analysis results (for example, for the default branch). Depending on your configuration and choice of analysis tool, future pull requests will be annotated with code scanning analysis results. For more information about GitHub code scanning, check out the documentation. |
|
|
||
| # Default values | ||
| src_dir="." | ||
| dst_dir="$HOME/.cargo/bin/dtdl-validator" |
There was a problem hiding this comment.
I don't think this should be the default since it's managed by cargo and we're not using cargo to do this installation
There was a problem hiding this comment.
Leaving as is for now until we have a better option.
* Removed DTDL Parser * Removed DTDL Parser * Removed DTDL Parser * Removed DTDL Parser * Removed DTDL Parser * Removed DTDL Parser * Removed DTDL Parser * Removed DTDL Parser * Removed DTDL Parser * Removed DTDL Parser * Removed DTDL Parser * Removed DTDL Parser * Removed DTDL Parser * Removed DTDL Parser * Removed DTDL Parser * Removed DTDL Parser * Removed DTDL Parser * Removed DTDL Parser * Removed DTDL Parser * Removed DTDL Parser * Removed DTDL Parser * Removed DTDL Parser * Removed DTDL Parser * Removed DTDL Parser * Removed DTDL Parser * Removed DTDL Parser * Removed DTDL Parser * Removed DTDL Parser
