Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update diagrams and Managed Subscribe Readme #51

Merged
merged 3 commits into from
Oct 12, 2023
Merged

Update diagrams and Managed Subscribe Readme #51

merged 3 commits into from
Oct 12, 2023

Conversation

devkelley
Copy link
Contributor

This PR does the following things:

  • Updates Managed Subscribe sequence diagrams to show that the InVehicle Digital Twin and Managed Subscribe Module are under the same service of Ibeji.
  • Adds simplified sequence diagrams from the perspective of a consumer and a provider to show what actually is needed from each of them.

ashbeitz
ashbeitz reviewed Oct 9, 2023
View reviewed changes
Copy link
Contributor

@ashbeitz ashbeitz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A few comments. Please take a look.

docs/design/diagrams/managed_subscribe_interceptor_sequence.puml Show resolved Hide resolved
docs/design/diagrams/managed_subscribe_module_sequence.puml Show resolved Hide resolved
ashbeitz
ashbeitz approved these changes Oct 9, 2023
View reviewed changes
Copy link
Contributor

@ashbeitz ashbeitz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved.

@ashbeitz ashbeitz merged commit 3de8d13 into eclipse-ibeji:main Oct 12, 2023
9 of 11 checks passed
mobicatk pushed a commit to Mobica/EclipseSDV_ibeji that referenced this pull request Apr 24, 2024
@devkelley
Update diagrams and Managed Subscribe Readme (eclipse-ibeji#51)
8c01ce0 
* Update diagrams and Managed Subscribe Readme

* fix spelling mistake and add accepted words

* Update diagrams
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jorchiu jorchiu jorchiu approved these changes

@wilyle wilyle wilyle approved these changes

@ashbeitz ashbeitz ashbeitz approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@devkelley @ashbeitz @wilyle @jorchiu