Devkelley/find agemo w chariott #53
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wilyle
reviewed
Oct 13, 2023
| @@ -61,8 +64,9 @@ pub enum TopicAction { | |||
| #[derive(Debug, Deserialize)] | |||
| pub struct ConfigSettings { | |||
| pub base_authority: String, | |||
| pub managed_subscribe_uri: String, | |||
| pub managed_subscribe_uri: Option<String>, | |||
There was a problem hiding this comment.
consider using an enum for these new config entries so that it is truly mutually exclusive
There was a problem hiding this comment.
Updated to an enum, please take a look
| ---- consumer_settings.yaml ---- | ||
|
|
||
| ```yaml | ||
| invehicle_digital_twin_uri: "http://0.0.0.0:5010" |
There was a problem hiding this comment.
this is out of scope for this PR, but I think it would be very helpful to have sample configs for these so that users don't have to manually create them. might be worth creating an issue to track
There was a problem hiding this comment.
We should have a standardized config process for all of our services if possible. I will look into getting an issue created.
wilyle
approved these changes
Oct 13, 2023
mobicatk
pushed a commit
to Mobica/EclipseSDV_ibeji
that referenced
this pull request
Apr 24, 2024
* Add chariott support for Managed Subscribe * Update README with how to run chariott * fixed spacing errors * fixed grammar * Add enum for service's source * updated readme and fixed whitespace issues * minor change to discover_service_using_chariott * Added comments for structs and enum definitions
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update the Managed Subscribe module so that the Agemo service can be discovered by Chariott if desired. Added documentation explaining what needs to be changed to run the Managed Subscribe sample with Chariott.