iox-#2044 Deactivate deprecated 'cert-dcl21-cpp' rule

eclipse-iceoryx · Oct 21, 2023 · c2f9a77 · c2f9a77
1 parent 49d974b
commit c2f9a77
Show file tree

Hide file tree

Showing 4 changed files with 5 additions and 8 deletions.
diff --git a/.clang-tidy b/.clang-tidy
@@ -5,6 +5,9 @@
 # - hicpp-member-init (duplicate of cppcoreguidelines-pro-type-member-init)
 # - performance-move-const-arg (duplicate of hicpp-move-const-arg)
 # - bugprone-use-after-move (duplicate of hicpp-move-const-arg)
+#
+# NOTE: following checks are disabled because they are deprecated
+# - cert-dcl21-cpp
 
 Checks: '
 -*,
@@ -32,6 +35,8 @@ hicpp-*,
 -readability-use-anyofallof,
 -readability-named-parameter,
 
+-cert-dcl21-cpp
+
 '
 
 ### Temporarily disabled because massive API changes:

diff --git a/iceoryx_dust/vocabulary/include/iox/detail/span_iterator.hpp b/iceoryx_dust/vocabulary/include/iox/detail/span_iterator.hpp
@@ -80,8 +80,6 @@ class span_iterator final
         return *this;
     }
 
-    // Rule DCL21-CPP is deprecated
-    // NOLINTNEXTLINE(cert-dcl21-cpp)
     constexpr span_iterator operator++(int) noexcept
     {
         span_iterator ret = *this;
@@ -97,8 +95,6 @@ class span_iterator final
         return *this;
     }
 
-    // Rule DCL21-CPP is deprecated
-    // NOLINTNEXTLINE(cert-dcl21-cpp)
     constexpr span_iterator operator--(int) noexcept
     {
         span_iterator ret = *this;

diff --git a/iceoryx_hoofs/design/include/iox/detail/newtype/decrementable.hpp b/iceoryx_hoofs/design/include/iox/detail/newtype/decrementable.hpp
@@ -36,8 +36,6 @@ struct Decrementable
         return Derived{--internal::newTypeRefAccessor(self)};
     }
 
-    // Rule DCL21-CPP is deprecated
-    // NOLINTNEXTLINE(cert-dcl21-cpp)
     friend Derived operator--(T& self, int) noexcept
     {
         return Derived{internal::newTypeRefAccessor(self)--};

diff --git a/iceoryx_hoofs/design/include/iox/detail/newtype/incrementable.hpp b/iceoryx_hoofs/design/include/iox/detail/newtype/incrementable.hpp
@@ -36,8 +36,6 @@ struct Incrementable
         return Derived{++internal::newTypeRefAccessor(self)};
     }
 
-    // Rule DCL21-CPP is deprecated
-    // NOLINTNEXTLINE(cert-dcl21-cpp)
     friend Derived operator++(T& self, int) noexcept
     {
         return Derived{internal::newTypeRefAccessor(self)++};