Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

iox-#2041 Move test class for ctor and assignment operator to hoofs testing #2042

Conversation

elBoberido
Copy link
Member

@elBoberido elBoberido commented Oct 15, 2023

Pre-Review Checklist for the PR Author

  1. Code follows the coding style of CONTRIBUTING.md
  2. Tests follow the best practice for testing
  3. Changelog updated in the unreleased section including API breaking changes
  4. Branch follows the naming format (iox-123-this-is-a-branch)
  5. Commits messages are according to this guideline
  6. Update the PR title
    • Follow the same conventions as for commit messages
    • Link to the relevant issue
  7. Relevant issues are linked
  8. Add sensible notes for the reviewer
  9. All checks have passed (except task-list-completed)
  10. All touched (C/C++) source code files from iceoryx_hoofs are added to ./clang-tidy-diff-scans.txt
  11. Assign PR to reviewer

Notes for Reviewer

I'm currently trying to replace the keep-alive mechanism from an IPC message to a timestamp in the shared memory. For this I needed to refactor the FixedPositionContainer and this in turn needs a test class for cTor and assignment operators. This PR moves the CTorTest class from the vector tests into a location where it can be reused by other tests.

Checklist for the PR Reviewer

  • Commits are properly organized and messages are according to the guideline
  • Code according to our coding style and naming conventions
  • Unit tests have been written for new behavior
  • Public API changes are documented via doxygen
  • Copyright owner are updated in the changed files
  • All touched (C/C++) source code files from iceoryx_hoofs have been added to ./clang-tidy-diff-scans.txt
  • PR title describes the changes

Post-review Checklist for the PR Author

  1. All open points are addressed and tracked via issues

References

@elBoberido
Copy link
Member Author

@FerdinandSpitzschnueffler @mossmaurice @dkroenke @MatthiasKillat @elfenpiff feel free to add yourself as reviewer

@elBoberido elBoberido self-assigned this Oct 15, 2023
@elBoberido elBoberido added the refactoring Refactor code without adding features label Oct 15, 2023
@elBoberido elBoberido changed the title iox-#2041 move test class for ctor and assignment operator to hoofs testing iox-#2041 Move test class for ctor and assignment operator to hoofs testing Oct 15, 2023
@elBoberido
Copy link
Member Author

@FerdinandSpitzschnueffler muchas gracias :)

@mossmaurice mossmaurice self-requested a review October 24, 2023 12:54
@elBoberido elBoberido force-pushed the iox-2041-move-test-class-for-ctor-and-assignment-operator-to-hoofs-testing branch from 3b56e28 to 91ec2be Compare October 24, 2023 14:32
@codecov
Copy link

codecov bot commented Oct 24, 2023

Codecov Report

Merging #2042 (91ec2be) into master (36f0c44) will increase coverage by 1.72%.
Report is 3 commits behind head on master.
The diff coverage is 32.47%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2042      +/-   ##
==========================================
+ Coverage   72.71%   74.44%   +1.72%     
==========================================
  Files         417      417              
  Lines       16285    15986     -299     
  Branches     2887     2272     -615     
==========================================
+ Hits        11842    11901      +59     
+ Misses       3469     3304     -165     
+ Partials      974      781     -193     
Flag Coverage Δ
unittests 74.23% <32.47%> (+1.72%) ⬆️
unittests_timing 15.31% <0.00%> (+0.28%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
...ceoryx_binding_c/source/c2cpp_enum_translation.cpp 100.00% <100.00%> (+10.81%) ⬆️
iceoryx_binding_c/source/c_publisher.cpp 92.50% <100.00%> (+3.75%) ⬆️
iceoryx_binding_c/source/c_subscriber.cpp 91.56% <100.00%> (+3.61%) ⬆️
iceoryx_binding_c/source/c_user_trigger.cpp 94.44% <100.00%> (+5.55%) ⬆️
...eoryx_hoofs/design/source/functional_interface.cpp 100.00% <100.00%> (+33.33%) ⬆️
...include/iceoryx_hoofs/posix_wrapper/posix_call.hpp 100.00% <ø> (ø)
iceoryx_hoofs/memory/source/bump_allocator.cpp 100.00% <100.00%> (+8.33%) ⬆️
iceoryx_hoofs/primitives/include/iox/size.hpp 50.00% <ø> (ø)
iceoryx_hoofs/reporting/include/iox/logging.hpp 50.00% <ø> (ø)
iceoryx_hoofs/source/cxx/requires.cpp 100.00% <100.00%> (+16.66%) ⬆️
... and 80 more

... and 1 file with indirect coverage changes

Copy link
Contributor

@mossmaurice mossmaurice left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm approving this PR as it already has one approval. However, I'm not a big fan of the name of the new class CTorAndAssignmentOperatorTestClass. Please check my proposals. Can also be adapted in a follow-up PR.

@elBoberido elBoberido merged commit c5f549f into master Oct 24, 2023
17 checks passed
@elBoberido elBoberido deleted the iox-2041-move-test-class-for-ctor-and-assignment-operator-to-hoofs-testing branch October 24, 2023 17:43
@elBoberido elBoberido linked an issue Oct 24, 2023 that may be closed by this pull request
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
refactoring Refactor code without adding features
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Move test class for ctor and assignment operators to hoofs testing
3 participants