-
Notifications
You must be signed in to change notification settings - Fork 398
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
iox-#2041 Move test class for ctor and assignment operator to hoofs testing #2042
iox-#2041 Move test class for ctor and assignment operator to hoofs testing #2042
Conversation
@FerdinandSpitzschnueffler @mossmaurice @dkroenke @MatthiasKillat @elfenpiff feel free to add yourself as reviewer |
@FerdinandSpitzschnueffler muchas gracias :) |
…ntOperatorTestClass'
3b56e28
to
91ec2be
Compare
Codecov Report
@@ Coverage Diff @@
## master #2042 +/- ##
==========================================
+ Coverage 72.71% 74.44% +1.72%
==========================================
Files 417 417
Lines 16285 15986 -299
Branches 2887 2272 -615
==========================================
+ Hits 11842 11901 +59
+ Misses 3469 3304 -165
+ Partials 974 781 -193
Flags with carried forward coverage won't be shown. Click here to find out more.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm approving this PR as it already has one approval. However, I'm not a big fan of the name of the new class CTorAndAssignmentOperatorTestClass
. Please check my proposals. Can also be adapted in a follow-up PR.
Pre-Review Checklist for the PR Author
iox-123-this-is-a-branch
)iox-#123 commit text
)task-list-completed
)iceoryx_hoofs
are added to./clang-tidy-diff-scans.txt
Notes for Reviewer
I'm currently trying to replace the keep-alive mechanism from an IPC message to a timestamp in the shared memory. For this I needed to refactor the
FixedPositionContainer
and this in turn needs a test class for cTor and assignment operators. This PR moves theCTorTest
class from thevector
tests into a location where it can be reused by other tests.Checklist for the PR Reviewer
iceoryx_hoofs
have been added to./clang-tidy-diff-scans.txt
Post-review Checklist for the PR Author
References