-
Notifications
You must be signed in to change notification settings - Fork 403
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
iox-#2044 Use new fixed position container #2053
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
elBoberido
added
refactoring
Refactor code without adding features
technical debt
unclean code and design flaws
labels
Oct 21, 2023
elBoberido
force-pushed
the
iox-2044-use-new-fixed-position-container
branch
2 times, most recently
from
October 22, 2023 18:31
cd13569
to
854ccb8
Compare
elBoberido
changed the base branch from
master
to
iox-2044-refactor-fixed-position-container-and-move-to-dust
October 22, 2023 18:51
@FerdinandSpitzschnueffler @mossmaurice @dkroenke @MatthiasKillat @elfenpiff @budrus feel free to add yourself as reviewer |
elBoberido
force-pushed
the
iox-2044-refactor-fixed-position-container-and-move-to-dust
branch
from
October 24, 2023 14:37
b0c2b66
to
d9c3857
Compare
elBoberido
changed the base branch from
iox-2044-refactor-fixed-position-container-and-move-to-dust
to
master
October 24, 2023 14:59
elBoberido
force-pushed
the
iox-2044-use-new-fixed-position-container
branch
from
October 24, 2023 15:02
854ccb8
to
6ca8bab
Compare
elBoberido
changed the base branch from
master
to
iox-2044-refactor-fixed-position-container-and-move-to-dust
October 24, 2023 15:02
elBoberido
force-pushed
the
iox-2044-refactor-fixed-position-container-and-move-to-dust
branch
from
October 24, 2023 17:48
d9c3857
to
66d544d
Compare
elBoberido
force-pushed
the
iox-2044-use-new-fixed-position-container
branch
from
October 24, 2023 21:24
6ca8bab
to
cf8a168
Compare
Codecov Report
@@ Coverage Diff @@
## master #2053 +/- ##
==========================================
- Coverage 80.23% 80.20% -0.04%
==========================================
Files 419 417 -2
Lines 16208 16188 -20
Branches 2298 2284 -14
==========================================
- Hits 13005 12984 -21
- Misses 2384 2388 +4
+ Partials 819 816 -3
Flags with carried forward coverage won't be shown. Click here to find out more.
|
Base automatically changed from
iox-2044-refactor-fixed-position-container-and-move-to-dust
to
master
October 25, 2023 15:18
elBoberido
changed the title
[Stacked on #2051] iox-#2044 Use new fixed position container
iox-#2044 Use new fixed position container
Oct 25, 2023
elBoberido
force-pushed
the
iox-2044-use-new-fixed-position-container
branch
from
October 25, 2023 21:46
cf8a168
to
71233e8
Compare
FerdinandSpitzschnueffler
approved these changes
Oct 27, 2023
elfenpiff
approved these changes
Oct 30, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pre-Review Checklist for the PR Author
iox-123-this-is-a-branch
)iox-#123 commit text
)task-list-completed
)iceoryx_hoofs
are added to./clang-tidy-diff-scans.txt
Notes for Reviewer
I'm currently trying to replace the keep-alive mechanism from an IPC message to a timestamp in the shared memory. This is the final preparatory PR which used the new
FixedPositionContainer
to replace the current stop gap solutions.Checklist for the PR Reviewer
iceoryx_hoofs
have been added to./clang-tidy-diff-scans.txt
Post-review Checklist for the PR Author
References