Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

iox-#2044 Use new fixed position container #2053

Merged
merged 2 commits into from
Oct 30, 2023

Conversation

elBoberido
Copy link
Member

@elBoberido elBoberido commented Oct 21, 2023

Pre-Review Checklist for the PR Author

  1. Code follows the coding style of CONTRIBUTING.md
  2. Tests follow the best practice for testing
  3. Changelog updated in the unreleased section including API breaking changes
  4. Branch follows the naming format (iox-123-this-is-a-branch)
  5. Commits messages are according to this guideline
  6. Update the PR title
    • Follow the same conventions as for commit messages
    • Link to the relevant issue
  7. Relevant issues are linked
  8. Add sensible notes for the reviewer
  9. All checks have passed (except task-list-completed)
  10. All touched (C/C++) source code files from iceoryx_hoofs are added to ./clang-tidy-diff-scans.txt
  11. Assign PR to reviewer

Notes for Reviewer

I'm currently trying to replace the keep-alive mechanism from an IPC message to a timestamp in the shared memory. This is the final preparatory PR which used the new FixedPositionContainer to replace the current stop gap solutions.

Checklist for the PR Reviewer

  • Commits are properly organized and messages are according to the guideline
  • Code according to our coding style and naming conventions
  • Unit tests have been written for new behavior
  • Public API changes are documented via doxygen
  • Copyright owner are updated in the changed files
  • All touched (C/C++) source code files from iceoryx_hoofs have been added to ./clang-tidy-diff-scans.txt
  • PR title describes the changes

Post-review Checklist for the PR Author

  1. All open points are addressed and tracked via issues

References

@elBoberido elBoberido added refactoring Refactor code without adding features technical debt unclean code and design flaws labels Oct 21, 2023
@elBoberido elBoberido self-assigned this Oct 21, 2023
@elBoberido elBoberido force-pushed the iox-2044-use-new-fixed-position-container branch 2 times, most recently from cd13569 to 854ccb8 Compare October 22, 2023 18:31
@elBoberido elBoberido changed the base branch from master to iox-2044-refactor-fixed-position-container-and-move-to-dust October 22, 2023 18:51
@elBoberido
Copy link
Member Author

@FerdinandSpitzschnueffler @mossmaurice @dkroenke @MatthiasKillat @elfenpiff @budrus feel free to add yourself as reviewer

@elBoberido elBoberido force-pushed the iox-2044-refactor-fixed-position-container-and-move-to-dust branch from b0c2b66 to d9c3857 Compare October 24, 2023 14:37
@elBoberido elBoberido changed the base branch from iox-2044-refactor-fixed-position-container-and-move-to-dust to master October 24, 2023 14:59
@elBoberido elBoberido force-pushed the iox-2044-use-new-fixed-position-container branch from 854ccb8 to 6ca8bab Compare October 24, 2023 15:02
@elBoberido elBoberido changed the base branch from master to iox-2044-refactor-fixed-position-container-and-move-to-dust October 24, 2023 15:02
@elBoberido elBoberido force-pushed the iox-2044-refactor-fixed-position-container-and-move-to-dust branch from d9c3857 to 66d544d Compare October 24, 2023 17:48
@elBoberido elBoberido force-pushed the iox-2044-use-new-fixed-position-container branch from 6ca8bab to cf8a168 Compare October 24, 2023 21:24
@codecov
Copy link

codecov bot commented Oct 24, 2023

Codecov Report

Merging #2053 (71233e8) into master (2a0be7b) will decrease coverage by 0.04%.
Report is 5 commits behind head on master.
The diff coverage is 90.09%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2053      +/-   ##
==========================================
- Coverage   80.23%   80.20%   -0.04%     
==========================================
  Files         419      417       -2     
  Lines       16208    16188      -20     
  Branches     2298     2284      -14     
==========================================
- Hits        13005    12984      -21     
- Misses       2384     2388       +4     
+ Partials      819      816       -3     
Flag Coverage Δ
unittests 79.99% <90.09%> (-0.04%) ⬇️
unittests_timing 15.12% <0.00%> (+0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
...nternal/roudi/introspection/port_introspection.hpp 100.00% <ø> (ø)
...clude/iceoryx_posh/internal/roudi/port_manager.inl 100.00% <ø> (ø)
...oryx_posh/include/iceoryx_posh/roudi/port_pool.hpp 100.00% <ø> (ø)
...oryx_posh/include/iceoryx_posh/roudi/port_pool.inl 100.00% <100.00%> (ø)
iceoryx_posh/source/roudi/port_pool.cpp 100.00% <100.00%> (ø)
iceoryx_posh/source/roudi/port_manager.cpp 86.12% <94.21%> (+0.61%) ⬆️
...nternal/roudi/introspection/port_introspection.inl 84.58% <72.00%> (-0.31%) ⬇️

... and 1 file with indirect coverage changes

Base automatically changed from iox-2044-refactor-fixed-position-container-and-move-to-dust to master October 25, 2023 15:18
@elBoberido elBoberido changed the title [Stacked on #2051] iox-#2044 Use new fixed position container iox-#2044 Use new fixed position container Oct 25, 2023
@elBoberido elBoberido force-pushed the iox-2044-use-new-fixed-position-container branch from cf8a168 to 71233e8 Compare October 25, 2023 21:46
@elBoberido elBoberido merged commit 775c7ac into master Oct 30, 2023
@elBoberido elBoberido deleted the iox-2044-use-new-fixed-position-container branch October 30, 2023 20:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
refactoring Refactor code without adding features technical debt unclean code and design flaws
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Refactor 'FixdePositionContainer' and move to 'dust'
3 participants