iox-#2274 Fix clang-tidy-18 warnings

[elBoberido]

Notes for Reviewer

To prevent issues with the upcoming Ubuntu 24.04 release which has clang-tidy-18, this PR fixes all the new warnings introduced between clang-tidy-15 and clang-tidy-18

Pre-Review Checklist for the PR Author

1. Code follows the coding style of CONTRIBUTING.md
2. Tests follow the best practice for testing
3. Changelog updated in the unreleased section including API breaking changes
4. Branch follows the naming format (iox-123-this-is-a-branch)
5. Commits messages are according to this guideline
   • Commit messages have the issue ID (iox-#123 commit text)
   • Commit author matches Eclipse Contributor Agreement (and ECA is signed)
6. Update the PR title
   • Follow the same conventions as for commit messages
   • Link to the relevant issue
7. Relevant issues are linked
8. Add sensible notes for the reviewer
9. All checks have passed (except task-list-completed)
10. Assign PR to reviewer

Checklist for the PR Reviewer

• Consider a second reviewer for complex new features or larger refactorings
• Commits are properly organized and messages are according to the guideline
• Code according to our coding style and naming conventions
• Unit tests have been written for new behavior
• Public API changes are documented via doxygen
• Copyright owner are updated in the changed files
• All touched (C/C++) source code files from iceoryx_hoofs have been added to ./clang-tidy-diff-scans.txt
• PR title describes the changes

Post-review Checklist for the PR Author

1. All open points are addressed and tracked via issues

References

• Closes Fix new clang-tidy-18 warnings #2274

[codecov]

Codecov Report

Attention: Patch coverage is 34.28571% with 23 lines in your changes are missing coverage. Please review.

Project coverage is 78.06%. Comparing base (e880982) to head (b9ab7ee).

Additional details and impacted files

@@            Coverage Diff             @@
##             main    #2275      +/-   ##
==========================================
- Coverage   78.12%   78.06%   -0.06%     
==========================================
  Files         432      432              
  Lines       15898    15912      +14     
  Branches     2297     2303       +6     
==========================================
+ Hits        12420    12422       +2     
- Misses       2631     2644      +13     
+ Partials      847      846       -1     

Flag	Coverage Δ
unittests	77.89% <34.28%> (-0.06%)	⬇️
unittests_timing	14.95% <8.57%> (-0.02%)	⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files	Coverage Δ
iceoryx_hoofs/buffer/include/iox/detail/stack.inl	94.02% <ø> (ø)
...detail/mpmc_lockfree_queue/mpmc_lockfree_queue.inl	98.24% <ø> (ø)
..._lockfree_queue/mpmc_resizeable_lockfree_queue.inl	90.41% <100.00%> (ø)
...oofs/container/include/iox/detail/forward_list.inl	91.28% <100.00%> (ø)
...ceoryx_hoofs/container/include/iox/detail/list.inl	91.23% <ø> (ø)
...oryx_hoofs/container/include/iox/detail/vector.inl	96.31% <ø> (ø)
...container/include/iox/fixed_position_container.hpp	100.00% <ø> (ø)
..._hoofs/design/include/iox/move_and_copy_helper.hpp	100.00% <ø> (ø)
...eoryx_hoofs/filesystem/include/iox/file_reader.hpp	100.00% <ø> (ø)
...ceoryx_hoofs/filesystem/include/iox/filesystem.hpp	100.00% <ø> (ø)
... and 46 more

... and 1 file with indirect coverage changes