Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

iox-#2011 Remove stale .clang-tidy symlink #2291

Conversation

forestf255
Copy link
Contributor

@forestf255 forestf255 commented May 16, 2024

Notes for Reviewer

Pre-Review Checklist for the PR Author

  1. Code follows the coding style of CONTRIBUTING.md
  2. Tests follow the best practice for testing
  3. Changelog updated in the unreleased section including API breaking changes
  4. Branch follows the naming format (iox-123-this-is-a-branch)
  5. Commits messages are according to this guideline
  6. Update the PR title
    • Follow the same conventions as for commit messages
    • Link to the relevant issue
  7. Relevant issues are linked
  8. Add sensible notes for the reviewer
  9. All checks have passed (except task-list-completed)
  10. Assign PR to reviewer

Checklist for the PR Reviewer

  • Consider a second reviewer for complex new features or larger refactorings
  • Commits are properly organized and messages are according to the guideline
  • Code according to our coding style and naming conventions
  • Unit tests have been written for new behavior
  • Public API changes are documented via doxygen
  • Copyright owner are updated in the changed files
  • All touched (C/C++) source code files from iceoryx_hoofs have been added to ./clang-tidy-diff-scans.txt
  • PR title describes the changes

Post-review Checklist for the PR Author

  1. All open points are addressed and tracked via issues

References

Relates to #2011

@forestf255 forestf255 force-pushed the iox-2011-remove-stale-clang-tidy-symlink branch from 71734d6 to 0a021d0 Compare May 16, 2024 02:16
Copy link
Member

@elBoberido elBoberido left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks for your contribution

Copy link

codecov bot commented May 16, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 78.07%. Comparing base (f6dc4e1) to head (0a021d0).

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #2291      +/-   ##
==========================================
+ Coverage   78.06%   78.07%   +0.01%     
==========================================
  Files         432      432              
  Lines       15912    15912              
  Branches     2303     2303              
==========================================
+ Hits        12421    12424       +3     
+ Misses       2644     2643       -1     
+ Partials      847      845       -2     
Flag Coverage Δ
unittests 77.90% <ø> (+0.01%) ⬆️
unittests_timing 14.96% <ø> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

see 2 files with indirect coverage changes

@elBoberido elBoberido merged commit 4a41c33 into eclipse-iceoryx:main May 16, 2024
24 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants