-
Notifications
You must be signed in to change notification settings - Fork 398
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
iox-#2325 support bzlmod #2338
iox-#2325 support bzlmod #2338
Conversation
@wep21 wow, this was fast. Thanks very much for taking care of this. We have still users who are relying on the old WORKSPACE approach so we might need to restore some of the deleted files for the time being. I'll check whether the users I know of are able to use dependencies which use bzlmod. If this is indeed the case, this can be merged as is (once the CI is green), if not the files from the Anyway, it's is great to move this forward :) Edit: It seems that there are some issues with |
Signed-off-by: wep21 <[email protected]>
Signed-off-by: wep21 <[email protected]>
I restored old files once and added
Let me check the error. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2338 +/- ##
=======================================
Coverage 78.22% 78.23%
=======================================
Files 433 433
Lines 16034 16033 -1
Branches 2302 2299 -3
=======================================
Hits 12543 12543
- Misses 2644 2647 +3
+ Partials 847 843 -4
Flags with carried forward coverage won't be shown. Click here to find out more. |
Signed-off-by: wep21 <[email protected]>
Signed-off-by: wep21 <[email protected]>
Signed-off-by: wep21 <[email protected]>
Signed-off-by: wep21 <[email protected]>
Signed-off-by: wep21 <[email protected]>
Signed-off-by: wep21 <[email protected]>
Signed-off-by: wep21 <[email protected]>
Just wanted to merge but then I noticed that there is no entry in the changelig. Can you please add an entry to the feature section of |
Signed-off-by: wep21 <[email protected]>
added at 417eaba |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@wep21 thanks for your contribution and your patience. If you like to continue with bazel, there is some work on iceoryx2 which we could look at.
Notes for Reviewer
Pre-Review Checklist for the PR Author
iox-123-this-is-a-branch
)iox-#123 commit text
)task-list-completed
)Checklist for the PR Reviewer
iceoryx_hoofs
have been added to./clang-tidy-diff-scans.txt
Post-review Checklist for the PR Author
References