Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

iox-#2011 Pin bazel to v7.4.1 on CI #2387

Conversation

elBoberido
Copy link
Member

@elBoberido elBoberido commented Dec 10, 2024

Notes for Reviewer

The CI upgraded bazel to v8.0.0 and this breaks the bazel setup. We currently support only bazel up to v7.4.1.

Pre-Review Checklist for the PR Author

  1. Code follows the coding style of CONTRIBUTING.md
  2. Tests follow the best practice for testing
  3. Changelog updated in the unreleased section including API breaking changes
  4. Branch follows the naming format (iox-123-this-is-a-branch)
  5. Commits messages are according to this guideline
  6. Update the PR title
    • Follow the same conventions as for commit messages
    • Link to the relevant issue
  7. Relevant issues are linked
  8. Add sensible notes for the reviewer
  9. All checks have passed (except task-list-completed)
  10. Assign PR to reviewer

Checklist for the PR Reviewer

  • Consider a second reviewer for complex new features or larger refactorings
  • Commits are properly organized and messages are according to the guideline
  • Code according to our coding style and naming conventions
  • Unit tests have been written for new behavior
  • Public API changes are documented via doxygen
  • Copyright owner are updated in the changed files
  • All touched (C/C++) source code files from iceoryx_hoofs have been added to ./clang-tidy-diff-scans.txt
  • PR title describes the changes

Post-review Checklist for the PR Author

  1. All open points are addressed and tracked via issues

References

@elBoberido elBoberido force-pushed the iox-2011-fix-bazel-build-after-CI-bazel-update branch from bb5c0f3 to 51a208c Compare December 10, 2024 23:11
@elBoberido elBoberido requested a review from elfenpiff December 10, 2024 23:12
@elBoberido elBoberido self-assigned this Dec 10, 2024
@elBoberido elBoberido force-pushed the iox-2011-fix-bazel-build-after-CI-bazel-update branch from 51a208c to bbeee8a Compare December 10, 2024 23:35
@elBoberido elBoberido mentioned this pull request Dec 10, 2024
21 tasks
@elBoberido elBoberido changed the title iox-#2011 Fix bazel build after bazel update to v8.0 on CI iox-#2011 Pin bazel to v7.4.1 on CI Dec 11, 2024
Copy link

codecov bot commented Dec 11, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 78.69%. Comparing base (11aa7f3) to head (bbeee8a).
Report is 2 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #2387   +/-   ##
=======================================
  Coverage   78.69%   78.69%           
=======================================
  Files         440      440           
  Lines       16981    16981           
  Branches     2361     2361           
=======================================
+ Hits        13363    13364    +1     
  Misses       2736     2736           
+ Partials      882      881    -1     
Flag Coverage Δ
unittests 78.49% <ø> (+<0.01%) ⬆️
unittests_timing 15.36% <ø> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

see 1 file with indirect coverage changes

@elBoberido elBoberido requested a review from orecham December 11, 2024 00:09
@elBoberido elBoberido merged commit 085ac0a into eclipse-iceoryx:main Dec 11, 2024
22 checks passed
@elBoberido elBoberido deleted the iox-2011-fix-bazel-build-after-CI-bazel-update branch December 11, 2024 07:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants