Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[#483] Add --send-copy flag to pub/sub benchmark #484

Merged

Conversation

elfenpiff
Copy link
Contributor

@elfenpiff elfenpiff commented Oct 21, 2024

Notes for Reviewer

The benchmark did not consider memory operations. It was true zero copy, meaning that the user used the API so that the data is directly produced into the shared memory and then sent. With the --send-copy flag the memory is zero'ed under the hood so that it simulates some memory operations.

Pre-Review Checklist for the PR Author

  1. Add sensible notes for the reviewer
  2. PR title is short, expressive and meaningful
  3. Relevant issues are linked in the References section
  4. Every source code file has a copyright header with SPDX-License-Identifier: Apache-2.0 OR MIT
  5. Branch follows the naming format (iox2-123-introduce-posix-ipc-example)
  6. Commits messages are according to this guideline
  7. Tests follow the best practice for testing
  8. Changelog updated in the unreleased section including API breaking changes
  9. Assign PR to reviewer
  10. All checks have passed (except task-list-completed)

Checklist for the PR Reviewer

  • Commits are properly organized and messages are according to the guideline
  • Unit tests have been written for new behavior
  • Public API is documented
  • PR title describes the changes

Post-review Checklist for the PR Author

  1. All open points are addressed and tracked via issues

References

Closes #483

@elfenpiff elfenpiff self-assigned this Oct 21, 2024
@elfenpiff elfenpiff force-pushed the iox2-483-add-copy-to-benchmark branch from cc08d77 to 76f9ea8 Compare October 25, 2024 08:52
Copy link

codecov bot commented Oct 25, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 79.19%. Comparing base (5f6a0dc) to head (0859def).
Report is 2 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##             main     #484   +/-   ##
=======================================
  Coverage   79.19%   79.19%           
=======================================
  Files         200      200           
  Lines       23716    23716           
=======================================
+ Hits        18781    18783    +2     
+ Misses       4935     4933    -2     

see 6 files with indirect coverage changes

@elfenpiff elfenpiff force-pushed the iox2-483-add-copy-to-benchmark branch from 76f9ea8 to 0859def Compare October 25, 2024 09:13
@elfenpiff elfenpiff merged commit 72ff56e into eclipse-iceoryx:main Oct 25, 2024
44 of 47 checks passed
@elfenpiff elfenpiff deleted the iox2-483-add-copy-to-benchmark branch October 25, 2024 10:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Extend pub/sub benchmark to include memory ops
2 participants