Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[#493] add tests #494

Merged
merged 2 commits into from
Oct 30, 2024
Merged

Conversation

elfenpiff
Copy link
Contributor

@elfenpiff elfenpiff commented Oct 30, 2024

Notes for Reviewer

This PR adds tests that proof that a service exists as long as a single port is still available. The when a single port is still living the service can be opened, no longer be created, since it still exists etc.

Pre-Review Checklist for the PR Author

  1. Add sensible notes for the reviewer
  2. PR title is short, expressive and meaningful
  3. Relevant issues are linked in the References section
  4. Every source code file has a copyright header with SPDX-License-Identifier: Apache-2.0 OR MIT
  5. Branch follows the naming format (iox2-123-introduce-posix-ipc-example)
  6. Commits messages are according to this guideline
  7. Tests follow the best practice for testing
  8. Changelog updated in the unreleased section including API breaking changes
  9. Assign PR to reviewer
  10. All checks have passed (except task-list-completed)

Checklist for the PR Reviewer

  • Commits are properly organized and messages are according to the guideline
  • Unit tests have been written for new behavior
  • Public API is documented
  • PR title describes the changes

Post-review Checklist for the PR Author

  1. All open points are addressed and tracked via issues

References

Closes #493

@elfenpiff elfenpiff requested a review from orecham October 30, 2024 14:21
@elfenpiff elfenpiff self-assigned this Oct 30, 2024
Copy link

codecov bot commented Oct 30, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 79.13%. Comparing base (98a4142) to head (c72fd7c).
Report is 3 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #494      +/-   ##
==========================================
- Coverage   79.16%   79.13%   -0.04%     
==========================================
  Files         200      200              
  Lines       23724    23724              
==========================================
- Hits        18782    18774       -8     
- Misses       4942     4950       +8     

see 6 files with indirect coverage changes

@elfenpiff elfenpiff merged commit 336513d into eclipse-iceoryx:main Oct 30, 2024
44 of 47 checks passed
@elfenpiff elfenpiff deleted the iox2-493-add-tests branch October 30, 2024 16:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add pubsub/event tests to ensure service is usable when ports still exist
2 participants