[#498] cleanup message type details #499
Merged
Task list completed / task-list-completed
succeeded
Nov 6, 2024 in 0s
16 / 16 tasks completed
All tasks have been completed
Details
Required Tasks
| Task | Status |
|---|---|
When overriding the MessageTypeDetails you must use [CustomPayloadMarker] as message type |
Incomplete |
You can only loan samples via Publisher::loan_custom_payload() |
Incomplete |
You can only receive samples via Subscriber::receive_custom_payload(). |
Incomplete |
| Add sensible notes for the reviewer | Completed |
| PR title is short, expressive and meaningful | Completed |
| Relevant issues are linked in the References section | Completed |
Every source code file has a copyright header with SPDX-License-Identifier: Apache-2.0 OR MIT |
Completed |
Branch follows the naming format (iox2-123-introduce-posix-ipc-example) |
Completed |
Commit messages have the issue ID ([#123] Add posix ipc example) |
Completed |
| Commit author matches [Eclipse Contributor Agreement][eca] (and ECA is signed) | Completed |
| Tests follow the [best practice for testing][testing] | Completed |
| Changelog updated [in the unreleased section][changelog] including API breaking changes | Completed |
| Assign PR to reviewer | Completed |
All checks have passed (except task-list-completed) |
Completed |
| Commits are properly organized and messages are according to the guideline | Completed |
| Unit tests have been written for new behavior | Completed |
| Public API is documented | Completed |
| PR title describes the changes | Completed |
| All open points are addressed and tracked via issues | Completed |
| payload == all bytes that belong to the user produced data | Incomplete |
| slice can be a form of payload | Incomplete |
| a slice consists of 1..N elements, therefore we have in this context an element_size? | Incomplete |
Loading