Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[#507] waitset adjustments #509

Merged

[#507] Clippy warnings and doc tests

71c4db4
Select commit
Loading
Failed to load commit list.
Merged

[#507] waitset adjustments #509

[#507] Clippy warnings and doc tests
71c4db4
Select commit
Loading
Failed to load commit list.
Task list completed / task-list-completed succeeded Nov 12, 2024 in 0s

16 / 16 tasks completed

All tasks have been completed

Details

Required Tasks

Task Status
DeadlineQueue::missed_deadlines() callback needs to return CallbackProgression so that the user is able to stop handling missed deadlines when required. Incomplete
behavior adjusted, blocks until the first event arrives, then handles all events and returns, to make it usable in external event loops. Incomplete
WaitSet::wait_and_process and WaitSet::wait_and_process_once callbacks need to return CallbackProgression to terminate event handling whenever required - this replaces the buggy WaitSet::stop() call. Incomplete
Add sensible notes for the reviewer Completed
PR title is short, expressive and meaningful Completed
Relevant issues are linked in the References section Completed
Every source code file has a copyright header with SPDX-License-Identifier: Apache-2.0 OR MIT Completed
Branch follows the naming format (iox2-123-introduce-posix-ipc-example) Completed
Commit messages have the issue ID ([#123] Add posix ipc example) Completed
Commit author matches [Eclipse Contributor Agreement][eca] (and ECA is signed) Completed
Tests follow the [best practice for testing][testing] Completed
Changelog updated [in the unreleased section][changelog] including API breaking changes Completed
Assign PR to reviewer Completed
All checks have passed (except task-list-completed) Completed
Commits are properly organized and messages are according to the guideline Completed
Unit tests have been written for new behavior Completed
Public API is documented Completed
PR title describes the changes Completed
All open points are addressed and tracked via issues Completed