Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[#496] disable slice specific builder methods #511

Conversation

elfenpiff
Copy link
Contributor

@elfenpiff elfenpiff commented Nov 12, 2024

Notes for Reviewer

The max_slice_len builder option is available for Publishers that have a non-slice payload which is an API-Bug. This PR makes max_slice_len available only to Publishers of payload iox::Slice<T>

Pre-Review Checklist for the PR Author

  1. Add sensible notes for the reviewer
  2. PR title is short, expressive and meaningful
  3. Relevant issues are linked in the References section
  4. Every source code file has a copyright header with SPDX-License-Identifier: Apache-2.0 OR MIT
  5. Branch follows the naming format (iox2-123-introduce-posix-ipc-example)
  6. Commits messages are according to this guideline
  7. Tests follow the best practice for testing
  8. Changelog updated in the unreleased section including API breaking changes
  9. Assign PR to reviewer
  10. All checks have passed (except task-list-completed)

Checklist for the PR Reviewer

  • Commits are properly organized and messages are according to the guideline
  • Unit tests have been written for new behavior
  • Public API is documented
  • PR title describes the changes

Post-review Checklist for the PR Author

  1. All open points are addressed and tracked via issues

References

Relates to #496

@elfenpiff elfenpiff requested a review from elBoberido November 12, 2024 10:22
@elfenpiff elfenpiff self-assigned this Nov 12, 2024
@elfenpiff elfenpiff force-pushed the iox2-496-disable-slice-specific-builder-methods branch from 8a6403d to 2a91131 Compare November 12, 2024 10:30
Copy link

codecov bot commented Nov 12, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 79.30%. Comparing base (5b8e6ee) to head (2a91131).
Report is 3 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #511      +/-   ##
==========================================
- Coverage   79.32%   79.30%   -0.03%     
==========================================
  Files         200      200              
  Lines       23757    23757              
==========================================
- Hits        18845    18840       -5     
- Misses       4912     4917       +5     

see 4 files with indirect coverage changes

@elfenpiff elfenpiff merged commit 9463c6d into eclipse-iceoryx:main Nov 12, 2024
46 of 47 checks passed
@elfenpiff elfenpiff deleted the iox2-496-disable-slice-specific-builder-methods branch November 12, 2024 13:03
@orecham
Copy link
Contributor

orecham commented Nov 12, 2024

Ugh my bad, you did mention this but I somehow lost track of it in the slice PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants