Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[#3] Skip CI if PR title starts with 'WIP' #513

Merged

Conversation

elBoberido
Copy link
Member

@elBoberido elBoberido commented Nov 12, 2024

Notes for Reviewer

This PR adds another check to skip the CI if the PR has draft status.

Pre-Review Checklist for the PR Author

  1. Add sensible notes for the reviewer
  2. PR title is short, expressive and meaningful
  3. Relevant issues are linked in the References section
  4. Every source code file has a copyright header with SPDX-License-Identifier: Apache-2.0 OR MIT
  5. Branch follows the naming format (iox2-123-introduce-posix-ipc-example)
  6. Commits messages are according to this guideline
  7. Tests follow the best practice for testing
  8. Changelog updated in the unreleased section including API breaking changes
  9. Assign PR to reviewer
  10. All checks have passed (except task-list-completed)

Checklist for the PR Reviewer

  • Commits are properly organized and messages are according to the guideline
  • Unit tests have been written for new behavior
  • Public API is documented
  • PR title describes the changes

Post-review Checklist for the PR Author

  1. All open points are addressed and tracked via issues

References

Relates to #3

@elBoberido elBoberido changed the title [WIP] [#3] Skip CI if PR title starts with 'WIP' [#3] Skip CI if PR title starts with 'WIP' Nov 12, 2024
@elBoberido elBoberido changed the title [#3] Skip CI if PR title starts with 'WIP' [WIP] [#3] Skip CI if PR title starts with 'WIP' Nov 12, 2024
elfenpiff
elfenpiff previously approved these changes Nov 14, 2024
@elBoberido elBoberido changed the title [WIP] [#3] Skip CI if PR title starts with 'WIP' [#3] Skip CI if PR title starts with 'WIP' Nov 20, 2024
@elBoberido elBoberido changed the title [#3] Skip CI if PR title starts with 'WIP' [WIP] [#3] Skip CI if PR title starts with 'WIP' Nov 20, 2024
@elfenpiff
Copy link
Contributor

elfenpiff commented Nov 20, 2024

@elBoberido I would like to merge this. Can we do this? But if you want to tweak it a bit more, could you then also add an entry into the FAQ_ICEORYX_DEVS.md file?

elfenpiff
elfenpiff previously approved these changes Nov 20, 2024
@elBoberido
Copy link
Member Author

@elfenpiff this does not work as expected. I'd like to be able to manually trigger the CI after the PT title changed but unfortunately, when the initially failed PR re-runs, it checks the old PR title and it is not possible to trigger the CI without having a dummy push after removing the [WIP]

@elBoberido elBoberido force-pushed the iox2-3-skip-CI-for-wip-pr branch from d4d5df9 to 852bcd5 Compare December 3, 2024 12:49
@elBoberido elBoberido changed the title [WIP] [#3] Skip CI if PR title starts with 'WIP' [#3] Skip CI if PR title starts with 'WIP' Dec 3, 2024
@elBoberido elBoberido changed the title [#3] Skip CI if PR title starts with 'WIP' [WIP] [#3] Skip CI if PR title starts with 'WIP' Dec 3, 2024
@elBoberido elBoberido force-pushed the iox2-3-skip-CI-for-wip-pr branch 3 times, most recently from 18c5d17 to 4a1f074 Compare December 3, 2024 13:13
@elBoberido elBoberido changed the title [WIP] [#3] Skip CI if PR title starts with 'WIP' [#3] Skip CI if PR title starts with 'WIP' Dec 3, 2024
@elBoberido elBoberido force-pushed the iox2-3-skip-CI-for-wip-pr branch from 4a1f074 to 8605b18 Compare December 3, 2024 13:16
@elBoberido elBoberido requested a review from elfenpiff December 3, 2024 13:17
@elBoberido elBoberido marked this pull request as draft December 3, 2024 13:23
@elBoberido elBoberido force-pushed the iox2-3-skip-CI-for-wip-pr branch 2 times, most recently from c7d166e to 70e437e Compare December 3, 2024 13:25
@elBoberido elBoberido marked this pull request as ready for review December 3, 2024 13:26
@elBoberido elBoberido marked this pull request as draft December 3, 2024 13:28
@elBoberido elBoberido marked this pull request as ready for review December 3, 2024 13:29
@elBoberido elBoberido force-pushed the iox2-3-skip-CI-for-wip-pr branch 3 times, most recently from 12cb1d4 to 9dcdc13 Compare December 3, 2024 13:47
@elBoberido elBoberido force-pushed the iox2-3-skip-CI-for-wip-pr branch 2 times, most recently from 320982c to c7a88ac Compare December 3, 2024 13:49
@elBoberido elBoberido force-pushed the iox2-3-skip-CI-for-wip-pr branch from c7a88ac to 5e34bc8 Compare December 3, 2024 13:51
Comment on lines +25 to +27
* [ ] Changelog updated [in the unreleased section][changelog] including API
breaking changes
* [ ] Assign PR to reviewer
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd like to remove the 80 character limitation. This totally breaks the reading flow

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Shall we go for 110?

Copy link

codecov bot commented Dec 3, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 79.10%. Comparing base (9463c6d) to head (5e34bc8).
Report is 133 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #513      +/-   ##
==========================================
- Coverage   79.25%   79.10%   -0.15%     
==========================================
  Files         200      202       +2     
  Lines       23757    24815    +1058     
==========================================
+ Hits        18828    19630     +802     
- Misses       4929     5185     +256     

see 38 files with indirect coverage changes

@elBoberido elBoberido merged commit 417196f into eclipse-iceoryx:main Dec 3, 2024
47 of 48 checks passed
@elBoberido elBoberido deleted the iox2-3-skip-CI-for-wip-pr branch December 3, 2024 15:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants