-
Notifications
You must be signed in to change notification settings - Fork 46
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[#3] Skip CI if PR title starts with 'WIP' #513
[#3] Skip CI if PR title starts with 'WIP' #513
Conversation
@elBoberido I would like to merge this. Can we do this? But if you want to tweak it a bit more, could you then also add an entry into the |
@elfenpiff this does not work as expected. I'd like to be able to manually trigger the CI after the PT title changed but unfortunately, when the initially failed PR re-runs, it checks the old PR title and it is not possible to trigger the CI without having a dummy push after removing the |
d4d5df9
to
852bcd5
Compare
18c5d17
to
4a1f074
Compare
4a1f074
to
8605b18
Compare
c7d166e
to
70e437e
Compare
12cb1d4
to
9dcdc13
Compare
320982c
to
c7a88ac
Compare
c7a88ac
to
5e34bc8
Compare
* [ ] Changelog updated [in the unreleased section][changelog] including API | ||
breaking changes | ||
* [ ] Assign PR to reviewer |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'd like to remove the 80 character limitation. This totally breaks the reading flow
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Shall we go for 110?
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #513 +/- ##
==========================================
- Coverage 79.25% 79.10% -0.15%
==========================================
Files 200 202 +2
Lines 23757 24815 +1058
==========================================
+ Hits 18828 19630 +802
- Misses 4929 5185 +256 |
Notes for Reviewer
This PR adds another check to skip the CI if the PR has draft status.
Pre-Review Checklist for the PR Author
SPDX-License-Identifier: Apache-2.0 OR MIT
iox2-123-introduce-posix-ipc-example
)[#123] Add posix ipc example
)task-list-completed
)Checklist for the PR Reviewer
Post-review Checklist for the PR Author
References
Relates to #3