Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[#490] bugfix in cxx slice api #514

Merged

[#490] Return ImmutableSlice in immutable payload() method of SampleMut

c65c1f4
Select commit
Loading
Failed to load commit list.
Merged

[#490] bugfix in cxx slice api #514

[#490] Return ImmutableSlice in immutable payload() method of SampleMut
c65c1f4
Select commit
Loading
Failed to load commit list.
Task list completed / task-list-completed succeeded Nov 13, 2024 in 0s

16 / 16 tasks completed

All tasks have been completed

Details

Required Tasks

Task Status
Proper pointer const-ness when returning ImmutableSlice in non-mut payload() method Incomplete
Add sensible notes for the reviewer Completed
PR title is short, expressive and meaningful Completed
Relevant issues are linked in the References section Completed
Every source code file has a copyright header with SPDX-License-Identifier: Apache-2.0 OR MIT Completed
Branch follows the naming format (iox2-123-introduce-posix-ipc-example) Completed
Commit messages have the issue ID ([#123] Add posix ipc example) Completed
Commit author matches [Eclipse Contributor Agreement][eca] (and ECA is signed) Completed
Tests follow the [best practice for testing][testing] Completed
Changelog updated [in the unreleased section][changelog] including API breaking changes Completed
Assign PR to reviewer Completed
All checks have passed (except task-list-completed) Completed
Commits are properly organized and messages are according to the guideline Completed
Unit tests have been written for new behavior Completed
Public API is documented Completed
PR title describes the changes Completed
All open points are addressed and tracked via issues Completed