Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[#390] event based comm example #519

Merged
merged 11 commits into from
Nov 22, 2024

[#390] Make timing test more stable

dbf37d1
Select commit
Loading
Failed to load commit list.
Merged

[#390] event based comm example #519

[#390] Make timing test more stable
dbf37d1
Select commit
Loading
Failed to load commit list.
Task list completed / task-list-completed succeeded Nov 22, 2024 in 0s

16 / 16 tasks completed

All tasks have been completed

Details

Required Tasks

Task Status
Adds the Rust-version of a more complex event-driven communication example. The idea is that the publisher and subscriber emit explicitly a user-defined event whenever they do something like connect/disconnect/sent sample/receive sample/request history etc. Based on that example a C++ example will follow in a follow up PR. In the example the ports are part of a more generic ExamplePublisher or ExampleSubscriber that also contain an notifier/listener to wait or emit events that are related to them. It also provides a first preview how a high-level iceoryx2 API could look like, where the event notification and the message transport are no longer separated. Incomplete
Fixes a Bug in the WaitSet where it went into an infinite loop after the first deadline/interval has passed. The only thing here missing was to store the last time missed_deadlines was called in the deadline queue. Incomplete
Add sensible notes for the reviewer Completed
PR title is short, expressive and meaningful Completed
Relevant issues are linked in the References section Completed
Every source code file has a copyright header with SPDX-License-Identifier: Apache-2.0 OR MIT Completed
Branch follows the naming format (iox2-123-introduce-posix-ipc-example) Completed
Commit messages have the issue ID ([#123] Add posix ipc example) Completed
Commit author matches [Eclipse Contributor Agreement][eca] (and ECA is signed) Completed
Tests follow the [best practice for testing][testing] Completed
Changelog updated [in the unreleased section][changelog] including API breaking changes Completed
Assign PR to reviewer Completed
All checks have passed (except task-list-completed) Completed
Commits are properly organized and messages are according to the guideline Completed
Unit tests have been written for new behavior Completed
Public API is documented Completed
PR title describes the changes Completed
All open points are addressed and tracked via issues Completed
Flaky Tests Detection - Detect and resolve failed and flaky tests Incomplete
View more details on Task list completed