-
Notifications
You must be signed in to change notification settings - Fork 40
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[#525] resizable shm support #527
[#525] resizable shm support #527
Conversation
50d399e
to
5dfcfae
Compare
53a6c76
to
f656be3
Compare
c9decdb
to
4b58bec
Compare
pub const fn from_value(value: u64) -> PointerOffset { | ||
Self(value) | ||
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Food for thought. Shouldn't this be unsafe
?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why? You just create a PointerOffset
nothing can cause undefined behavior or a segfault here.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe I was thinking too much of Box::from_raw
but since one can create it from any offset + index, it would be moot.
…ads so that systems with many CPU cores can handle them as well
Notes for Reviewer
Makes the ZeroCopyConnection concept multi segment capable. Instead of using of UsedChunkList, that tracks all outgoing samples to recover them when a subscriber dies, we have now one UsedChunkList per segment.
The user can define how many segments at most the ZeroCopyConnection can manage in parallel. This is useful to avoid the overhead in the case that one has a static type and not the slice case as payload.
Pre-Review Checklist for the PR Author
SPDX-License-Identifier: Apache-2.0 OR MIT
iox2-123-introduce-posix-ipc-example
)[#123] Add posix ipc example
)task-list-completed
)Checklist for the PR Reviewer
Post-review Checklist for the PR Author
References
Closes #525