Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[#528] make signal registration optional #529

Conversation

elfenpiff
Copy link
Contributor

@elfenpiff elfenpiff commented Nov 26, 2024

Notes for Reviewer

When users use a third party signal handler, the waitset or node signal handler might override previous setups. A builder option was added to both to make the signal handler mode configurable.

Pre-Review Checklist for the PR Author

  1. Add sensible notes for the reviewer
  2. PR title is short, expressive and meaningful
  3. Relevant issues are linked in the References section
  4. Every source code file has a copyright header with SPDX-License-Identifier: Apache-2.0 OR MIT
  5. Branch follows the naming format (iox2-123-introduce-posix-ipc-example)
  6. Commits messages are according to this guideline
  7. Tests follow the best practice for testing
  8. Changelog updated in the unreleased section including API breaking changes
  9. Assign PR to reviewer
  10. All checks have passed (except task-list-completed)

Checklist for the PR Reviewer

  • Commits are properly organized and messages are according to the guideline
  • Unit tests have been written for new behavior
  • Public API is documented
  • PR title describes the changes

Post-review Checklist for the PR Author

  1. All open points are addressed and tracked via issues

References

Relates to #528

@elfenpiff elfenpiff requested a review from orecham November 26, 2024 16:12
@elfenpiff elfenpiff self-assigned this Nov 26, 2024
@elfenpiff elfenpiff force-pushed the iox2-528-make-signal-registration-optional branch from 7a7c747 to 7decc19 Compare November 26, 2024 16:15
iceoryx2/src/node/mod.rs Outdated Show resolved Hide resolved
iceoryx2/src/port/waitset.rs Outdated Show resolved Hide resolved
@elfenpiff elfenpiff requested a review from orecham November 26, 2024 19:19
@elfenpiff elfenpiff merged commit 11a446f into eclipse-iceoryx:main Nov 27, 2024
45 checks passed
@elfenpiff elfenpiff deleted the iox2-528-make-signal-registration-optional branch November 27, 2024 09:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants