Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[#264] Fix accessability of 'FileDescriptorView' methods #530

Conversation

elBoberido
Copy link
Member

@elBoberido elBoberido commented Nov 27, 2024

Notes for Reviewer

All methods of FileDescriptorView are private but file_descriptor and unsafe_native_handle needs to be public.

Pre-Review Checklist for the PR Author

  1. Add sensible notes for the reviewer
  2. PR title is short, expressive and meaningful
  3. Relevant issues are linked in the References section
  4. Every source code file has a copyright header with SPDX-License-Identifier: Apache-2.0 OR MIT
  5. Branch follows the naming format (iox2-123-introduce-posix-ipc-example)
  6. Commits messages are according to this guideline
  7. [ x Tests follow the best practice for testing
  8. Changelog updated in the unreleased section including API breaking changes
  9. Assign PR to reviewer
  10. All checks have passed (except task-list-completed)

Checklist for the PR Reviewer

  • Commits are properly organized and messages are according to the guideline
  • Unit tests have been written for new behavior
  • Public API is documented
  • PR title describes the changes

Post-review Checklist for the PR Author

  1. All open points are addressed and tracked via issues

References

Relates to #264

@elBoberido elBoberido requested a review from elfenpiff November 27, 2024 12:29
@elBoberido elBoberido self-assigned this Nov 27, 2024
@elBoberido elBoberido merged commit 91e0de5 into eclipse-iceoryx:main Nov 27, 2024
12 of 13 checks passed
@elBoberido elBoberido deleted the iox2-264-fix-accessability-of-file-descriptor-native-handle-in-cxx-api branch November 27, 2024 12:35
Copy link

codecov bot commented Nov 27, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 78.89%. Comparing base (11a446f) to head (48f2d71).
Report is 2 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #530      +/-   ##
==========================================
- Coverage   78.93%   78.89%   -0.05%     
==========================================
  Files         201      201              
  Lines       24237    24237              
==========================================
- Hits        19131    19121      -10     
- Misses       5106     5116      +10     

see 8 files with indirect coverage changes

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants