Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[#491] Ensure enum string literals are null terminated #538

Merged
merged 5 commits into from
Dec 23, 2024

[#491] Simplify implementation of CStrRepr

c5ee757
Select commit
Loading
Failed to load commit list.
Merged

[#491] Ensure enum string literals are null terminated #538

[#491] Simplify implementation of CStrRepr
c5ee757
Select commit
Loading
Failed to load commit list.
Task list completed / task-list-completed Started 2024-12-23 16:42:54 ago

15 / 16 tasks completed

1 task still to be completed

Details

Required Tasks

Task Status
Trait: AsCStr which provides as_const_cstr() method, const alluding to the fact it is in .rodata Incomplete
Macro: CStrRepr so #[derive(CStrRepr)] reads more naturally Incomplete
The trait explicitly returns the CStr type Incomplete
Move CStrRepr macro into iceoryx2-ffi-macros since it is only used by iceoryx2-ffi Incomplete
Add sensible notes for the reviewer Completed
PR title is short, expressive and meaningful Completed
Relevant issues are linked in the References section Completed
Every source code file has a copyright header with SPDX-License-Identifier: Apache-2.0 OR MIT Completed
Branch follows the naming format (iox2-123-introduce-posix-ipc-example) Completed
Commit messages have the issue ID ([#123] Add posix ipc example) Completed
Commit author matches [Eclipse Contributor Agreement][eca] (and ECA is signed) Completed
Tests follow the [best practice for testing][testing] Completed
Changelog updated [in the unreleased section][changelog] including API breaking changes Incomplete
Assign PR to reviewer Completed
All checks have passed (except task-list-completed) Completed
Commits are properly organized and messages are according to the guideline Completed
Unit tests have been written for new behavior Completed
Public API is documented Completed
PR title describes the changes Completed
All open points are addressed and tracked via issues Completed
The trait explicitly returns the CStr type Incomplete
Trait: AsCStr which provides as_const_cstr() method, const alluding to the fact it is in .rodata Incomplete
Macro: CStrRepr so #[derive(CStrRepr)] reads more naturally Incomplete
Move CStrRepr macro into iceoryx2-ffi-macros since it is only used by iceoryx2-ffi Incomplete
View more details on Task list completed