-
Notifications
You must be signed in to change notification settings - Fork 40
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[#532] resizable shm support in publisher #540
Merged
elfenpiff
merged 27 commits into
eclipse-iceoryx:main
from
elfenpiff:iox2-532-resizable-shm-support-in-publisher
Dec 5, 2024
Merged
[#532] resizable shm support in publisher #540
elfenpiff
merged 27 commits into
eclipse-iceoryx:main
from
elfenpiff:iox2-532-resizable-shm-support-in-publisher
Dec 5, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
elfenpiff
changed the title
WIP [#532] resizable shm support in publisher
[#532] resizable shm support in publisher
Dec 4, 2024
elfenpiff
force-pushed
the
iox2-532-resizable-shm-support-in-publisher
branch
3 times, most recently
from
December 4, 2024 14:33
ce5a374
to
a2184c1
Compare
elfenpiff
requested review from
elBoberido and
orecham
and removed request for
elBoberido
December 4, 2024 14:37
…trategy of the publisher; rename max_slice_len into initial_max_slice_len
…ervice segment; add data segment type to the publisher port details
…dle multi segments
…refcount == 0 and new segment is mapped
elfenpiff
force-pushed
the
iox2-532-resizable-shm-support-in-publisher
branch
from
December 4, 2024 14:54
ff1deaa
to
ec0bc59
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #540 +/- ##
==========================================
+ Coverage 79.13% 79.18% +0.04%
==========================================
Files 202 203 +1
Lines 24887 25123 +236
==========================================
+ Hits 19695 19894 +199
- Misses 5192 5229 +37
|
elfenpiff
force-pushed
the
iox2-532-resizable-shm-support-in-publisher
branch
2 times, most recently
from
December 4, 2024 19:26
5f8df9e
to
d6da7fc
Compare
elBoberido
reviewed
Dec 5, 2024
elfenpiff
force-pushed
the
iox2-532-resizable-shm-support-in-publisher
branch
3 times, most recently
from
December 5, 2024 13:29
356a507
to
d6da7fc
Compare
elfenpiff
force-pushed
the
iox2-532-resizable-shm-support-in-publisher
branch
from
December 5, 2024 14:48
d6da7fc
to
b150b78
Compare
elBoberido
previously approved these changes
Dec 5, 2024
…layout requirement description
elfenpiff
force-pushed
the
iox2-532-resizable-shm-support-in-publisher
branch
from
December 5, 2024 15:47
d514f1d
to
f08c0a0
Compare
elBoberido
approved these changes
Dec 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Notes for Reviewer
Integrates the resizable shared memory into the publisher and subscriber.
DataSegment
that abstracts the resizable and non-resizable shared memory handlingDataSegment
class is used by theSubscriber
andPublisher
and will be later used also by theServer
andClient
max_slice_len
intoinitial_max_slice_len
to make it clear that this is not an absolut limit but it is the initial estimationPoolAllocator::deallocate_bucket()
that does not require a layout since all buckets have the same layout - allows us to not track the individual layout of a sample only the segment idsend
for the zero copy connection to be able to calculate the tracker index inside the connection. Currently, the zero-copy connection has an indirect hard dependency to a pool allocator.Pre-Review Checklist for the PR Author
SPDX-License-Identifier: Apache-2.0 OR MIT
iox2-123-introduce-posix-ipc-example
)[#123] Add posix ipc example
)task-list-completed
)Checklist for the PR Reviewer
Post-review Checklist for the PR Author
References
Closes #532