Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[#3] Trigger CI when a PR changes from draft to ready #541

Conversation

elBoberido
Copy link
Member

Notes for Reviewer

Prevent CI from running on each commit while the work is still in progress

  • Set the PR to a draft status, e.g. by the Convert to draft link, to indicate
    that the work is not yet ready for review
  • Once the PR is ready for review, press the Ready for Review button and push
    a final commit to trigger the CI

Pre-Review Checklist for the PR Author

  • Add sensible notes for the reviewer
  • PR title is short, expressive and meaningful
  • Relevant issues are linked in the References section
  • Every source code file has a copyright header with
    SPDX-License-Identifier: Apache-2.0 OR MIT
  • Branch follows the naming format (iox2-123-introduce-posix-ipc-example)
  • Commits messages are according to this guideline
  • Tests follow the best practice for testing
  • Changelog updated in the unreleased section including API
    breaking changes
  • Assign PR to reviewer
  • All checks have passed (except task-list-completed)

Checklist for the PR Reviewer

  • Commits are properly organized and messages are according to the guideline
  • Unit tests have been written for new behavior
  • Public API is documented
  • PR title describes the changes

Post-review Checklist for the PR Author

  • All open points are addressed and tracked via issues

References

Closes #

@elBoberido elBoberido marked this pull request as ready for review December 4, 2024 12:49
@elBoberido elBoberido force-pushed the iox2-3-skip-CI-for-draft-pr branch from ce7f9da to 9e37177 Compare December 4, 2024 12:52
@elBoberido elBoberido force-pushed the iox2-3-skip-CI-for-draft-pr branch from 9e37177 to 7abfe3c Compare December 4, 2024 12:55
@elBoberido elBoberido closed this Dec 4, 2024
Copy link

codecov bot commented Dec 4, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 79.10%. Comparing base (0ad8d53) to head (7abfe3c).

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #541      +/-   ##
==========================================
- Coverage   79.13%   79.10%   -0.03%     
==========================================
  Files         202      202              
  Lines       24887    24887              
==========================================
- Hits        19695    19688       -7     
- Misses       5192     5199       +7     

see 4 files with indirect coverage changes

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant