Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[#264] cxx bindings for attributes #549

Open
wants to merge 11 commits into
base: main
Choose a base branch
from

Conversation

elfenpiff
Copy link
Contributor

@elfenpiff elfenpiff commented Dec 16, 2024

Adds the c/c++ binding for attributes and integrates them into the service builder.

Notes for Reviewer

Pre-Review Checklist for the PR Author

  • Add sensible notes for the reviewer
  • PR title is short, expressive and meaningful
  • Consider switching the PR to a draft (Convert to draft)
    • as draft PR, the CI will be skipped for pushes
  • Relevant issues are linked in the References section
  • Every source code file has a copyright header with SPDX-License-Identifier: Apache-2.0 OR MIT
  • Branch follows the naming format (iox2-123-introduce-posix-ipc-example)
  • Commits messages are according to this guideline
  • Tests follow the best practice for testing
  • Changelog updated in the unreleased section including API breaking changes
  • Assign PR to reviewer
  • All checks have passed (except task-list-completed)

Checklist for the PR Reviewer

  • Commits are properly organized and messages are according to the guideline
  • Unit tests have been written for new behavior
  • Public API is documented
  • PR title describes the changes

Post-review Checklist for the PR Author

  • All open points are addressed and tracked via issues

References

Relates to #264

@elfenpiff elfenpiff marked this pull request as ready for review December 16, 2024 12:22
@elfenpiff elfenpiff requested a review from elBoberido December 16, 2024 12:23
@elfenpiff elfenpiff self-assigned this Dec 16, 2024
Copy link

codecov bot commented Dec 16, 2024

Codecov Report

Attention: Patch coverage is 22.22222% with 14 lines in your changes missing coverage. Please review.

Please upload report for BASE (main@a628ba5). Learn more about missing BASE report.

Files with missing lines Patch % Lines
iceoryx2/src/service/attribute.rs 22.22% 14 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##             main     #549   +/-   ##
=======================================
  Coverage        ?   79.07%           
=======================================
  Files           ?      203           
  Lines           ?    25146           
  Branches        ?        0           
=======================================
  Hits            ?    19885           
  Misses          ?     5261           
  Partials        ?        0           
Files with missing lines Coverage Δ
iceoryx2/src/service/attribute.rs 84.94% <22.22%> (ø)

@elfenpiff elfenpiff force-pushed the iox2-264-cxx-bindings-for-attributes branch from 568053f to ce1a959 Compare December 16, 2024 13:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant