Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[#264] node id and remove stale resources of dead nodes #553

Merged

Conversation

elfenpiff
Copy link
Contributor

@elfenpiff elfenpiff commented Dec 18, 2024

Notes for Reviewer

Pre-Review Checklist for the PR Author

  • Add sensible notes for the reviewer
  • PR title is short, expressive and meaningful
  • Consider switching the PR to a draft (Convert to draft)
    • as draft PR, the CI will be skipped for pushes
  • Relevant issues are linked in the References section
  • Every source code file has a copyright header with SPDX-License-Identifier: Apache-2.0 OR MIT
  • Branch follows the naming format (iox2-123-introduce-posix-ipc-example)
  • Commits messages are according to this guideline
  • Tests follow the best practice for testing
  • Changelog updated in the unreleased section including API breaking changes
  • Assign PR to reviewer
  • All checks have passed (except task-list-completed)

Checklist for the PR Reviewer

  • Commits are properly organized and messages are according to the guideline
  • Unit tests have been written for new behavior
  • Public API is documented
  • PR title describes the changes

Post-review Checklist for the PR Author

  • All open points are addressed and tracked via issues

References

Closes #264

@elfenpiff elfenpiff requested a review from elBoberido December 18, 2024 23:04
@elfenpiff elfenpiff self-assigned this Dec 18, 2024
@elfenpiff elfenpiff force-pushed the iox2-264-remaining-cxx-bindings branch from 0f1107b to 8ff39fd Compare December 18, 2024 23:26
@elfenpiff elfenpiff force-pushed the iox2-264-remaining-cxx-bindings branch 7 times, most recently from 2467999 to 79d3940 Compare December 19, 2024 13:05
@elfenpiff elfenpiff force-pushed the iox2-264-remaining-cxx-bindings branch 2 times, most recently from 9e30a13 to 47802c0 Compare December 19, 2024 15:21
Copy link

codecov bot commented Dec 19, 2024

Codecov Report

Attention: Patch coverage is 0% with 14 lines in your changes missing coverage. Please review.

Project coverage is 79.03%. Comparing base (d332b3e) to head (0190c25).
Report is 4 commits behind head on main.

Files with missing lines Patch % Lines
iceoryx2/src/node/mod.rs 0.00% 14 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #553      +/-   ##
==========================================
- Coverage   79.07%   79.03%   -0.05%     
==========================================
  Files         203      203              
  Lines       25293    25307      +14     
==========================================
  Hits        20001    20001              
- Misses       5292     5306      +14     
Files with missing lines Coverage Δ
iceoryx2/src/node/mod.rs 67.84% <0.00%> (-1.07%) ⬇️

... and 8 files with indirect coverage changes

Copy link
Member

@elBoberido elBoberido left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. As soon as the CI is green, this can be merged

@elfenpiff elfenpiff force-pushed the iox2-264-remaining-cxx-bindings branch from 47802c0 to 0190c25 Compare December 19, 2024 18:13
@elfenpiff elfenpiff merged commit dc18bff into eclipse-iceoryx:main Dec 19, 2024
46 of 47 checks passed
@elfenpiff elfenpiff deleted the iox2-264-remaining-cxx-bindings branch December 19, 2024 19:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Create C++ language binding
2 participants