Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[#555] health monitoring example #557

Merged

Conversation

elfenpiff
Copy link
Contributor

@elfenpiff elfenpiff commented Dec 19, 2024

Notes for Reviewer

Pre-Review Checklist for the PR Author

  • Add sensible notes for the reviewer
  • PR title is short, expressive and meaningful
  • Consider switching the PR to a draft (Convert to draft)
    • as draft PR, the CI will be skipped for pushes
  • Relevant issues are linked in the References section
  • Every source code file has a copyright header with SPDX-License-Identifier: Apache-2.0 OR MIT
  • Branch follows the naming format (iox2-123-introduce-posix-ipc-example)
  • Commits messages are according to this guideline
  • Tests follow the best practice for testing
  • Changelog updated in the unreleased section including API breaking changes
  • Assign PR to reviewer
  • All checks have passed (except task-list-completed)

Checklist for the PR Reviewer

  • Commits are properly organized and messages are according to the guideline
  • Unit tests have been written for new behavior
  • Public API is documented
  • PR title describes the changes

Post-review Checklist for the PR Author

  • All open points are addressed and tracked via issues

References

Relates to #555

@elfenpiff elfenpiff requested a review from elBoberido December 19, 2024 18:09
@elfenpiff elfenpiff self-assigned this Dec 19, 2024
@elfenpiff elfenpiff changed the title [#555] health monitoring example BASED ON 553 [#555] health monitoring example Dec 19, 2024
@elfenpiff elfenpiff changed the title BASED ON 553 [#555] health monitoring example [#555] health monitoring example Dec 19, 2024
@elfenpiff elfenpiff force-pushed the iox2-555-health-monitoring-example branch 2 times, most recently from f5282b7 to e77a023 Compare December 19, 2024 19:51
elBoberido
elBoberido previously approved these changes Dec 19, 2024
Copy link

codecov bot commented Dec 19, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 78.99%. Comparing base (dc18bff) to head (b0484ea).
Report is 4 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #557      +/-   ##
==========================================
- Coverage   79.08%   78.99%   -0.10%     
==========================================
  Files         203      203              
  Lines       25307    25307              
==========================================
- Hits        20014    19990      -24     
- Misses       5293     5317      +24     

see 6 files with indirect coverage changes

@elfenpiff elfenpiff merged commit fcde364 into eclipse-iceoryx:main Dec 19, 2024
47 checks passed
@elfenpiff elfenpiff deleted the iox2-555-health-monitoring-example branch December 19, 2024 22:35
@orecham
Copy link
Contributor

orecham commented Dec 20, 2024

very cool @elfenpiff

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants