Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[#559] Reuse existing cargo build for C and C++ bindings #560

Conversation

elBoberido
Copy link
Member

@elBoberido elBoberido commented Dec 20, 2024

Notes for Reviewer

This PR adds a cmake option to use existing artifacts of the iceoryx2 cargo build.

The documentation is also updated and the CI uses this new mechanism to speed up the builds.

Pre-Review Checklist for the PR Author

  • Add sensible notes for the reviewer
  • PR title is short, expressive and meaningful
  • Consider switching the PR to a draft (Convert to draft)
    • as draft PR, the CI will be skipped for pushes
  • Relevant issues are linked in the References section
  • Every source code file has a copyright header with SPDX-License-Identifier: Apache-2.0 OR MIT
  • Branch follows the naming format (iox2-123-introduce-posix-ipc-example)
  • Commits messages are according to this guideline
  • Tests follow the best practice for testing
  • Changelog updated in the unreleased section including API breaking changes
  • Assign PR to reviewer
  • All checks have passed (except task-list-completed)

Checklist for the PR Reviewer

  • Commits are properly organized and messages are according to the guideline
  • Unit tests have been written for new behavior
  • Public API is documented
  • PR title describes the changes

Post-review Checklist for the PR Author

  • All open points are addressed and tracked via issues

References

Closes #559

@elBoberido elBoberido requested a review from elfenpiff December 20, 2024 15:17
@elBoberido elBoberido self-assigned this Dec 20, 2024
elfenpiff
elfenpiff previously approved these changes Dec 20, 2024
@elBoberido elBoberido merged commit 750ac04 into eclipse-iceoryx:main Dec 20, 2024
45 checks passed
@elBoberido elBoberido deleted the iox2-559-reuse-existing-cargo-build-for-cmake-ffi-build branch December 20, 2024 17:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Reuse existing cargo build with C and C++ bindings
2 participants