-
Notifications
You must be signed in to change notification settings - Fork 47
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[#64] Implement Display for MessagingPattern #65
Conversation
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #65 +/- ##
==========================================
- Coverage 77.97% 77.96% -0.02%
==========================================
Files 172 172
Lines 18729 18734 +5
==========================================
+ Hits 14604 14606 +2
- Misses 4125 4128 +3
|
cb0a148
to
bb6f4bc
Compare
9b99564
to
a2b9d92
Compare
@@ -107,12 +107,12 @@ fn udp_socket_when_socket_goes_out_of_scope_address_is_free_again() { | |||
fn udp_socket_server_has_correct_address() { | |||
let sut_server = UdpServerBuilder::new() | |||
.address(ipv4_address::LOCALHOST) | |||
.port(Port::new(65111)) | |||
.port(Port::new(55223)) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nothing for this PR and I think you already did it somewhere else but using an atomic base port number an atomically increasing it for each test will make these tests more robust.
Notes for Reviewer
Pre-Review Checklist for the PR Author
SPDX-License-Identifier: Apache-2.0 OR MIT
iox2-123-introduce-posix-ipc-example
)[#123] Add posix ipc example
)task-list-completed
)Checklist for the PR Reviewer
Post-review Checklist for the PR Author
References
Use either 'Closes #123' or 'Relates to #123' to reference the corresponding issue.
Closes #64
Closes #66