Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[#64] Implement Display for MessagingPattern #65

Merged
merged 3 commits into from
Jan 2, 2024

Conversation

elfenpiff
Copy link
Contributor

@elfenpiff elfenpiff commented Dec 30, 2023

Notes for Reviewer

Pre-Review Checklist for the PR Author

  1. Add sensible notes for the reviewer
  2. PR title is short, expressive and meaningful
  3. Relevant issues are linked
  4. Every source code file has a copyright header with SPDX-License-Identifier: Apache-2.0 OR MIT
  5. Branch follows the naming format (iox2-123-introduce-posix-ipc-example)
  6. Commits messages are according to this guideline
  7. Tests follow the best practice for testing
  8. Changelog updated in the unreleased section including API breaking changes
  9. Assign PR to reviewer
  10. All checks have passed (except task-list-completed)

Checklist for the PR Reviewer

  • Commits are properly organized and messages are according to the guideline
  • Unit tests have been written for new behavior
  • Public API is documented
  • PR title describes the changes

Post-review Checklist for the PR Author

  1. All open points are addressed and tracked via issues

References

Use either 'Closes #123' or 'Relates to #123' to reference the corresponding issue.

Closes #64
Closes #66

@elfenpiff elfenpiff requested a review from elBoberido December 30, 2023 11:05
@elfenpiff elfenpiff self-assigned this Dec 30, 2023
Copy link

codecov bot commented Dec 30, 2023

Codecov Report

Attention: 5 lines in your changes are missing coverage. Please review.

Comparison is base (26d979e) 77.97% compared to head (a2b9d92) 77.96%.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main      #65      +/-   ##
==========================================
- Coverage   77.97%   77.96%   -0.02%     
==========================================
  Files         172      172              
  Lines       18729    18734       +5     
==========================================
+ Hits        14604    14606       +2     
- Misses       4125     4128       +3     
Files Coverage Δ
iceoryx2/src/service/config_scheme.rs 91.17% <100.00%> (ø)
iceoryx2/src/service/messaging_pattern.rs 79.31% <0.00%> (-16.53%) ⬇️

... and 1 file with indirect coverage changes

@@ -107,12 +107,12 @@ fn udp_socket_when_socket_goes_out_of_scope_address_is_free_again() {
fn udp_socket_server_has_correct_address() {
let sut_server = UdpServerBuilder::new()
.address(ipv4_address::LOCALHOST)
.port(Port::new(65111))
.port(Port::new(55223))
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nothing for this PR and I think you already did it somewhere else but using an atomic base port number an atomically increasing it for each test will make these tests more robust.

@elfenpiff elfenpiff merged commit c3622ca into eclipse-iceoryx:main Jan 2, 2024
19 of 21 checks passed
@elfenpiff elfenpiff deleted the iox2-64-api-qol branch January 2, 2024 21:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Static config uses suffix of dynamic config MessagingPattern shall implement Display
2 participants