Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[#81] Add better log error output for signal handler failure #91

Conversation

elfenpiff
Copy link
Contributor

@elfenpiff elfenpiff commented Jan 16, 2024

Notes for Reviewer

Pre-Review Checklist for the PR Author

  1. Add sensible notes for the reviewer
  2. PR title is short, expressive and meaningful
  3. Relevant issues are linked
  4. Every source code file has a copyright header with SPDX-License-Identifier: Apache-2.0 OR MIT
  5. Branch follows the naming format (iox2-123-introduce-posix-ipc-example)
  6. Commits messages are according to this guideline
  7. Tests follow the best practice for testing
  8. Changelog updated in the unreleased section including API breaking changes
  9. Assign PR to reviewer
  10. All checks have passed (except task-list-completed)

Checklist for the PR Reviewer

  • Commits are properly organized and messages are according to the guideline
  • Unit tests have been written for new behavior
  • Public API is documented
  • PR title describes the changes

Post-review Checklist for the PR Author

  1. All open points are addressed and tracked via issues

References

Use either 'Closes #123' or 'Relates to #123' to reference the corresponding issue.

Relates to #81

@elfenpiff elfenpiff requested a review from elBoberido January 16, 2024 22:46
@elfenpiff elfenpiff self-assigned this Jan 16, 2024
@elfenpiff elfenpiff force-pushed the iox2-81-fix-signal-handler-second-try branch from b704d01 to 72bbda4 Compare January 16, 2024 22:46
elBoberido
elBoberido previously approved these changes Jan 16, 2024
@elfenpiff elfenpiff force-pushed the iox2-81-fix-signal-handler-second-try branch from 72bbda4 to 358a814 Compare January 16, 2024 22:50
@elfenpiff elfenpiff requested a review from elBoberido January 16, 2024 22:50
Copy link

codecov bot commented Jan 16, 2024

Codecov Report

Attention: 3 lines in your changes are missing coverage. Please review.

Comparison is base (891ae9b) 78.00% compared to head (491d1fa) 77.99%.
Report is 2 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main      #91      +/-   ##
==========================================
- Coverage   78.00%   77.99%   -0.01%     
==========================================
  Files         172      172              
  Lines       18778    18795      +17     
==========================================
+ Hits        14647    14660      +13     
- Misses       4131     4135       +4     
Files Coverage Δ
iceoryx2-bb/posix/src/signal.rs 84.52% <62.50%> (-0.50%) ⬇️

... and 3 files with indirect coverage changes

@elfenpiff elfenpiff force-pushed the iox2-81-fix-signal-handler-second-try branch from 358a814 to 491d1fa Compare January 16, 2024 22:55
@elfenpiff elfenpiff merged commit 9883c9b into eclipse-iceoryx:main Jan 16, 2024
19 of 23 checks passed
@elfenpiff elfenpiff deleted the iox2-81-fix-signal-handler-second-try branch January 16, 2024 23:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants