-
Notifications
You must be signed in to change notification settings - Fork 42
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[#96] decentral service artifact cleanup #97
[#96] decentral service artifact cleanup #97
Conversation
bda2b3e
to
c10f2fe
Compare
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #97 +/- ##
==========================================
- Coverage 77.94% 77.64% -0.31%
==========================================
Files 177 178 +1
Lines 18881 19222 +341
==========================================
+ Hits 14716 14924 +208
- Misses 4165 4298 +133
|
99a6498
to
e0f7fbb
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The process_state.rs
and its tests are something for tomorrow
4cef9f5
to
ca74aea
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I need to create a sequence diagram with all the things that could happen during a race between the application and the monitoring process. I somehow have the feeling that it is quite racy and especially when you start multiple applications at once, including the monitoring application, this could lead to unexpected results.
2fcf864
to
e2b7434
Compare
2603e18
to
fb82e10
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
An interim review. Need to finish process_state_tests.rs
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tests look good.
I'm just not sure if the terminology for the file names should be changed to something more generic than .cleaner
, e.g. .owner_lock
. It acts more or less as the lock file in iceoryx1.
Nothing to block this PR but something to think about.
fb82e10
to
28a3fc5
Compare
… inter process checks are possible
…g path or file name
…d normalize functionality to make it consistently hashable and comparable
20009e7
to
f599d17
Compare
4982a41
to
24e29e7
Compare
…, Guard and their interactions; code readability
24e29e7
to
a3bd5b3
Compare
Notes for Reviewer
FilePath::path()
andFilePath::file_name()
are returning aPath
orFileName
and no longer a slice. Makes it easier to use since it prevents either addition checks or unsafe sections. In some files, those unsafe sections were removed.process_state.rs
in posix, a basic building block to enable process monitoring. When this is merged, a concept iniceoryx2_cal
calledMonitor
will be introduced that will use this and provides a safe user API.Pre-Review Checklist for the PR Author
SPDX-License-Identifier: Apache-2.0 OR MIT
iox2-123-introduce-posix-ipc-example
)[#123] Add posix ipc example
)task-list-completed
)Checklist for the PR Reviewer
Post-review Checklist for the PR Author
References
Use either 'Closes #123' or 'Relates to #123' to reference the corresponding issue.
Relates to #96