ECJ emits different inner class references for the same code

[srikanth-sankaran]

What it does

Converge divergent signature management routines ensuring that we track nested member type references uniformly.
Fixes #1631

Author checklist

• I have thoroughly tested my changes
• The change is following the coding conventions
• I have signed the Eclipse Contributor Agreement (ECA)

[iloveeclipse]

@srikanth-sankaran : please next time avoid merging PR's that show errors. I know there are sometimes "checks" that are red without a good reason, but in general we are trying to keep the status green and so if anything is red it is most likely a sign of a problem with the PR. In doubt please just ask.

[srikanth-sankaran]

@iloveeclipse I restarted the tests a couple of times only for the symptoms of the failing checks to shift around.

I consulted with @jarthana and he asked me to go ahead since it "looks like the previous PRs that went in had the same problem." (Private chat)

FWIW

[srikanth-sankaran]

@iloveeclipse I restarted the tests a couple of times only for the symptoms of the failing checks to shift around.

I consulted with @jarthana and he asked me to go ahead since it "looks like the previous PRs that went in had the same problem." (Private chat)

FWIW

Ah, I see that what I took to be a temporary process glitch caused some grief around bundle numbers. Sorry about that!

[jarthana]

Oops! Sorry for the wrong and admittedly lazy advice. Off topic, it will be helpful if the failure reason (the version update) reported prominently rather then being buried in the log.