[23] Folding a markdown region hides the first line of subsequent Java #2943
+7
−4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This fix introduces a problem in a corner case when the markdown ends with a param or other incomplete tag and no whitespace before the closing \n, which is not part of the markdown doc. I have adjusted a testcase to pass, but will take that up via a different issue. |
jarthana
force-pushed
the
gh1615
branch
2 times, most recently
from
8a8304f to
e8b552b
Compare
|
OK, this is stuck with a hung test case. I don't think this is going in for the GA release. Will take it up post-merge. |
time to try again ? 😄 |
|
I recall this being held is related to eclipse-jdt/eclipse.jdt.ui#1848, which was on hold for another reason. But now I see that is green. Will take up both if time permits. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
code
What it does
Fixes eclipse-jdt/eclipse.jdt.ui#1615
How to test
Author checklist