Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Avoid NPE in DOMToModelConverter.toLocalVariable #3643

Merged
merged 1 commit into from
Feb 1, 2025
Merged

Avoid NPE in DOMToModelConverter.toLocalVariable #3643

merged 1 commit into from
Feb 1, 2025

Conversation

robstryker
Copy link
Contributor

@robstryker robstryker commented Jan 31, 2025 •
edited
Loading

Fixes eclipse-jdtls#1018

Note: This fixes an issue in an adopter project.

What it does

How to test

Author checklist

@rgrunber rgrunber added this to the 4.35 M3 milestone Feb 1, 2025
rgrunber
rgrunber approved these changes Feb 1, 2025
View reviewed changes
Copy link
Contributor

@rgrunber rgrunber left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes sense. node.getParent() from within domUnit(..) may end up returning a null.

@rgrunber rgrunber merged commit 642df71 into eclipse-jdt:master Feb 1, 2025
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rgrunber rgrunber rgrunber approved these changes

Assignees

@robstryker robstryker

Labels
None yet
Projects
None yet
Milestone
4.35 M3
Development

Successfully merging this pull request may close these issues.

NPE while hovering on debug
3 participants
@robstryker @rgrunber @mickaelistria