-
Notifications
You must be signed in to change notification settings - Fork 49
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Updated bundles with comparator errors #569
Conversation
d2d94ad
to
bbeb1e0
Compare
@@ -2,7 +2,7 @@ Manifest-Version: 1.0 | |||
Bundle-ManifestVersion: 2 | |||
Bundle-Name: %pluginName | |||
Bundle-SymbolicName: org.eclipse.jdt.debug.tests; singleton:=true | |||
Bundle-Version: 3.12.550.qualifier | |||
Bundle-Version: 3.12.650.qualifier |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks wrong. I don't know how 550 ended up in master (IMO it's failure from merging BETA_JAVA* branch FYI @jarthana ) . The bundle version should be 3.12.600 here.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please fix the o.e.jdt.debug.tests version.
Changes to ecj are for handling of switch on String. See: eclipse-platform/eclipse.platform.releng.aggregator#2595
bbeb1e0
to
8e21402
Compare
Thanks for taking a look @akurtakov ! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me now
Changes to ecj are for handling of switch on String.
See: eclipse-platform/eclipse.platform.releng.aggregator#2595
What it does
How to test
Author checklist