Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated bundles with comparator errors #569

Merged
merged 1 commit into from
Nov 27, 2024

Conversation

trancexpress
Copy link
Contributor

Changes to ecj are for handling of switch on String.

See: eclipse-platform/eclipse.platform.releng.aggregator#2595

What it does

How to test

Author checklist

@@ -2,7 +2,7 @@ Manifest-Version: 1.0
Bundle-ManifestVersion: 2
Bundle-Name: %pluginName
Bundle-SymbolicName: org.eclipse.jdt.debug.tests; singleton:=true
Bundle-Version: 3.12.550.qualifier
Bundle-Version: 3.12.650.qualifier
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks wrong. I don't know how 550 ended up in master (IMO it's failure from merging BETA_JAVA* branch FYI @jarthana ) . The bundle version should be 3.12.600 here.

Copy link
Contributor

@akurtakov akurtakov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please fix the o.e.jdt.debug.tests version.

@trancexpress
Copy link
Contributor Author

Please fix the o.e.jdt.debug.tests version.

Thanks for taking a look @akurtakov !

Copy link
Contributor

@akurtakov akurtakov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me now

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants