-
Notifications
You must be signed in to change notification settings - Fork 49
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Auto resume trigger breakpoints once hit #620
base: master
Are you sure you want to change the base?
Conversation
1c4768d
to
a4737ab
Compare
Hi @jukzi , could you pls check this when you have time.. |
62b4f94
to
3af58fc
Compare
Code looks fine. I am testing it, thanks for working on that!! And congrats to your Election. |
Thank you so much @jukzi 😇👏 |
/** | ||
* Suspend policy constant indicating a breakpoint will not suspend the target VM when hit. | ||
* | ||
* @since 3.5 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
expecting @since 3.22
00:01:32.006 [ERROR] Failed to execute goal org.eclipse.tycho:tycho-apitools-plugin:4.0.11:verify (verify) on project org.eclipse.jdt.debug: There are API errors:
00:01:32.006 [ERROR] model/org/eclipse/jdt/debug/core/IJavaBreakpoint.java:54 Invalid @since 3.5 tag on RESUME_THREAD; expecting @since 3.22
note that this change has to wait for M1 anyway and then you may need to bump one more time
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, will correct for next M1
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
fix API error
Will check this
Sure 👍 |
3af58fc
to
6f042e2
Compare
from editor This commit introduces an option to resume virtual machine execution when a trigger breakpoint is hit. This allows trigger breakpoints to act as barriers, enabling lower-priority breakpoints to remain active without needing to be disabled. Additionally, a new option has been added to the Java editor to toggle Triggerpoints, allowing users to instantly create a Resume-Triggerpoint. Fixes eclipse-jdt#614
6f042e2
to
c47e110
Compare
thanks for this example
fixed both now 👍 |
This PR introduces an option to resume the virtual machine execution once a trigger breakpoint is hit. This allows trigger breakpoints to act as barriers for other breakpoints, enabling less priority breakpoints to remain active without requiring them to be disabled.
Screens -


Once trigger is enabled then users will be able to choose 'Resume' , Selecting 'Resume' will also include 'Ignored' tag to breakpoint label
On debugging trigger wont suspend at breakpoint line, it will only suspend on next breakpoint
Additionally a new option has been added to the Java editor to toggle Triggerpoints, allowing users to
instantly create a Resume-Triggerpoint.
Fixes #614
What it does
How to test
Author checklist