Record classes are now handled the same as normal classes

eclipse-jdt · Dec 2, 2024 · 9dba2c3 · 9dba2c3
1 parent 9c7fbe4
commit 9dba2c3
Showing 1 changed file with 5 additions and 1 deletion.
diff --git a/...i/org/eclipse/jdt/internal/ui/javaeditor/codemining/CalleeJavaMethodParameterVisitor.java b/...i/org/eclipse/jdt/internal/ui/javaeditor/codemining/CalleeJavaMethodParameterVisitor.java
@@ -129,7 +129,7 @@ protected void collectParameterNamesCodeMinings(IMethod method, List<?> argument
 
 	protected void collectParameterNamesCodeMinings(IMethodBinding mbinding, List<?> arguments, boolean isVarArgs) {
 		// synthetic method of a record
-		if (mbinding.getDeclaringClass().isRecord()) {
+		if (mbinding.getDeclaringClass().isRecord() && !skipParameterNamesCodeMinings(mbinding)) {
 			String[] parameterNames= mbinding.getParameterNames();
 			for (int i= 0; i < Math.min(arguments.size(), parameterNames.length); i++) {
 				if (!skipParameterNameCodeMining(parameterNames, arguments, i)) {
@@ -168,6 +168,10 @@ private boolean skipParameterNamesCodeMinings(IMethod method) {
 		return method.getNumberOfParameters() <= 1;
 	}
 
+	private boolean skipParameterNamesCodeMinings(IMethodBinding methodBinding) {
+		return methodBinding.getParameterNames().length <= 1;
+	}
+
 	private boolean skipParameterNamesCodeMinings(IMethod method, String[] parameterNames) {
 		IPreferenceStore store= JavaPlugin.getDefault().getPreferenceStore();
 		boolean filter= store.getBoolean(PreferenceConstants.EDITOR_JAVA_CODEMINING_DEFAULT_FILTER_FOR_PARAMETER_NAMES);