Remove empty hamcrest-core 2.x from 'JUnit 4/5' classpath container #1612
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
3 tasks
HannesWell
force-pushed
the
remove-hamcrest-core
branch
from
c2e9ac6 to
7c2f7fc
Compare
akurtakov
force-pushed
the
remove-hamcrest-core
branch
from
7c2f7fc to
5dd1bab
Compare
HannesWell
force-pushed
the
remove-hamcrest-core
branch
from
5dd1bab to
72d0292
Compare
Since hamcrest version 2 the 'hamcrest-core' artifact only exists to redirect to the new 'hamcrest' artifact containing all of hamcrest. Therefore 'hamcrest-core' does only contains meteadata but no classes. For the 'JUnit 4/5' classpath container it is therefore useless in version 2 and later. References: - https://hamcrest.org/JavaHamcrest/distributables.html#previous-versions-of-hamcrest - https://github.com/hamcrest/JavaHamcrest/releases/tag/v2.1
HannesWell
force-pushed
the
remove-hamcrest-core
branch
from
72d0292 to
802584c
Compare
|
Will you handle removing it entirely from the sdk/builds? |
Yes, I'll check if there are any remaining's of hamcrest-core that we can remove. |
See For JDT the remaining references to hamcrest-core were already removed as part of |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What it does
Since hamcrest version 2 the 'hamcrest-core' artifact only exists to redirect to the new 'hamcrest' artifact containing all of hamcrest. Therefore 'hamcrest-core' does only contains meteadata but no classes. For the 'JUnit 4/5' classpath container it is therefore useless in version 2 and later.
References:
Author checklist