Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Silent OperationCanceledException during hover #1827 #1829

Merged
merged 1 commit into from
Dec 6, 2024

Conversation

jukzi
Copy link
Contributor

@jukzi jukzi commented Dec 4, 2024

If Operation is canceled result is just not needed anymore. No need to log an error.

  • also silent BadLocationException

#1827

@jukzi
Copy link
Contributor Author

jukzi commented Dec 4, 2024

same as // Just swallow the exception if the operation was canceled in org.eclipse.jface.text.TextViewerHoverManager.computeInformation()

@jukzi jukzi added bug Something isn't working regression Regression defect labels Dec 4, 2024
@jukzi jukzi linked an issue Dec 4, 2024 that may be closed by this pull request
@jukzi jukzi force-pushed the OperationCanceledException branch from cee7c7a to 73a9e09 Compare December 5, 2024 12:56
If Operation is canceled result is just not needed anymore. No need to
log an error.

* also silent BadLocationException

eclipse-jdt#1827
@jukzi jukzi force-pushed the OperationCanceledException branch from 73a9e09 to 1bd9cda Compare December 6, 2024 07:46
@jukzi
Copy link
Contributor Author

jukzi commented Dec 6, 2024

ignoring unrelated know 12 fails #1833

@jukzi jukzi merged commit 24f0dcc into eclipse-jdt:master Dec 6, 2024
7 of 10 checks passed
@jukzi jukzi deleted the OperationCanceledException branch December 6, 2024 09:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working regression Regression defect
Projects
None yet
Development

Successfully merging this pull request may close these issues.

hover logs OperationCanceledException as error
2 participants